The default bug view has changed. See this FAQ.

Kill VALUE_TO_BOOLEAN in interpreter

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: efaust, Assigned: efaust)

Tracking

unspecified
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 646018 [details] [diff] [review]
Patch

Bug 749536 renders VALUE_TO_BOOLEAN unnecessary. Kill it.
(Assignee)

Updated

5 years ago
Attachment #646018 - Flags: review?(luke)
(Assignee)

Updated

5 years ago
Assignee: general → efaust
Status: NEW → ASSIGNED

Updated

5 years ago
Attachment #646018 - Attachment is patch: true

Comment 1

5 years ago
Comment on attachment 646018 [details] [diff] [review]
Patch

I would even not mind if you inlined POP_BOOLEAN (since it takes two lines (for the declaration) in the caller anyways).
Attachment #646018 - Flags: review?(luke) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/19a7e39d99f2
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/19a7e39d99f2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.