Closed Bug 777618 Opened 10 years ago Closed 10 years ago

Kill VALUE_TO_BOOLEAN in interpreter

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: efaust, Assigned: efaust)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Attached patch PatchSplinter Review
Bug 749536 renders VALUE_TO_BOOLEAN unnecessary. Kill it.
Attachment #646018 - Flags: review?(luke)
Assignee: general → efaust
Status: NEW → ASSIGNED
Attachment #646018 - Attachment is patch: true
Comment on attachment 646018 [details] [diff] [review]
Patch

I would even not mind if you inlined POP_BOOLEAN (since it takes two lines (for the declaration) in the caller anyways).
Attachment #646018 - Flags: review?(luke) → review+
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/19a7e39d99f2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.