777700 - Graphics driver crash causes images to stop rendering

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Joshua Cranmer [:jcranmer]]

Periodically, my laptop appears to suffer from various graphics driver crashes and restarts. When this happens, on nightly builds, all images (including icons) suddenly disappear. This does not happen on current release version of Firefox (14 IIRC?).

Comment 1

[Bas Schouten (:bas.schouten)]

(In reply to Joshua Cranmer [:jcranmer] from comment #0)
> Periodically, my laptop appears to suffer from various graphics driver
> crashes and restarts. When this happens, on nightly builds, all images
> (including icons) suddenly disappear. This does not happen on current
> release version of Firefox (14 IIRC?).

This could be a symptom of Azure-content. I'll look into this, we'll probably be switching Azure off for 15 so that would fix this problem for you.

On another note though, what's your hardware and driver version, if it crashes that often it should probably be blacklisted for acceleration altogether.

Comment 2

[Joshua Cranmer [:jcranmer]]

From about:support:

Graphics
Adapter Description	NVIDIA Quadro FX 880M
Vendor ID	0x10de
Device ID	0x0a3c
Adapter RAM	1024
Adapter Drivers	nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Driver Version	8.17.12.5738
Driver Date	6-27-2010
Direct2D Enabled	true
DirectWrite Enabled	true (6.1.7601.17789)
ClearType Parameters	ClearType parameters not found
WebGL Renderer	Google Inc. -- ANGLE (NVIDIA Quadro FX 880M) -- OpenGL ES 2.0 (ANGLE 1.0.0.1041)
GPU Accelerated Windows	1/1 Direct3D 10
AzureBackend	direct2d

Comment 3

[Bas Schouten (:bas.schouten)]

Those drivers are only -just- not blacklisted. In general it would be good if you could upgrade, although the issue should still be fixed. I'm not sure if we should blacklist this card/driver combination.

Comment 4

[Joshua Cranmer [:jcranmer]]

I used to notice a few months ago some fairly frequent crashes (= multiple times per day), but nowadays the driver crashes are relatively rare, maybe once a week?

Comment 5

[Joe Drew (not getting mail)]

A lot of people have reported to me that graphics driver crashes make images disappear with azure content, fwiw.

Comment 6

[Bas Schouten (:bas.schouten)]

That just reaffirms my belief we should switch Azure content off on beta and fix these issues on Aurora (or rather, I will).

Comment 7

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Add functionality to check validity of a source surface

Since driver crash behaviour is somewhat hard to emulate, it's hard to say for sure, but I suspect I understand the problem. I've created some patches to verify cached source surfaces come from the correct device.

Comment 8

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Only use cached surface when it's valid.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 646638 [details] [diff] [review]
Part 1: Add functionality to check validity of a source surface

Review of attachment 646638 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/2D.h
@@ +303,5 @@
>    virtual IntSize GetSize() const = 0;
>    virtual SurfaceFormat GetFormat() const = 0;
>  
> +  /* This returns false if some event has made this source surface invalid for
> +   * usage with current DrawTargets.

Might want to add the example of what happens to D2D here.

::: gfx/2d/SourceSurfaceD2D.h
@@ +41,5 @@
>    friend class DrawTargetD2D;
>  
>    uint32_t GetByteSize() const;
>  
>    RefPtr<ID2D1Bitmap> mBitmap;

Add a comment about why we need to keep a pointer to the device

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 646639 [details] [diff] [review]
Part 2: Only use cached surface when it's valid.

Review of attachment 646639 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatform.cpp
@@ +20,5 @@
>  #if defined(XP_WIN)
>  #include "gfxWindowsPlatform.h"
>  #include "gfxD2DSurface.h"
> +
> +#include <d3d10_1.h>

Do we need this?

@@ +506,5 @@
> +    SourceSurface *surf = static_cast<SourceSurface*>(userData);
> +
> +    if (surf->IsValid()) {
> +      return surf;
> +    }

Will this surface be removed below?

Comment 11

[:Benjamin Peterson]

Backed out for windows failures: https://tbpl.mozilla.org/php/getParsedLog.php?id=13928781&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/2087e29da681
https://hg.mozilla.org/integration/mozilla-inbound/rev/8891aeee02e8

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Relanded with a clobber.

https://hg.mozilla.org/integration/mozilla-inbound/rev/efc8ca42f6d2
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8f77aeed77d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efc8ca42f6d2
https://hg.mozilla.org/mozilla-central/rev/f8f77aeed77d

Comment 14

[Joshua Cranmer [:jcranmer]]

Images remained around after my latest driver cache.