77773 - Search UI: Delete/Open buttons not enabling properly

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using apr26 commercial trunk build

The Delete button in the search messages UI never enables for single or multiple
selection.

Comment 1

[laurel]

I take that back... it never enables until after you've made a multiple selection.

Comment 2

[laurel]

Similar thing is happening for Open button.
Navin just stopped by and claims this has been there for awhile, that the
buttons get into a state where they don't work -- his workaround is to issue
another search whereas I seem to be able to get the enabled state(s) if doing a
multiple selection.

I took away the regression keyword, but this seemed to be working properly for
me within the past several days... I don't know, but in any case it needs to be
fixed.

Comment 3

[laurel]

Sometimes right click on a single selection will enable one/both the buttons.

Comment 4

[scottputterman]

Laurel,

are you still seeing this? I'm using the 4/29 build.  I do a search and as soon
as I select a message, open and file enable.  This is on Win 2000.

Comment 5

[laurel]

Still present, apr30 commercial trunk builds.

Comment 6

[scottputterman]

I see it. Open and File work fine for me, but delete doesn't always show up
until there's a multiple selection.

Comment 7

[gayatrib]

This seems to be working fine for me. I waited to update this bug--as I wanted 
to test it for a few days before doing so.
But it seems to be working fine in all the latest builds. 
Marking worksForMe.

Comment 8

[gayatrib]

looks like this is happening in release builds and not in debug builds. I will
try again tomorrow morning and try to identify the problem in the meantime.

Comment 9

[gayatrib]

Re-opening this bug--as it seems to be reproducible sometimes.

Comment 10

[gayatrib]

I am beginning to wonder if this is happening in the Classic skin only...?
When I change the them from classic to modern, it seems to go away.

Investigating further.

Please update with your comments--are you seeing it in both skins?

Comment 11

[scottputterman]

I'm only using modern and it doesn't work for me in today's release build.

Comment 12

[laurel]

This is still happening in both skins, and behaves much worse on Mac, by the way.

Comment 13

[scottputterman]

reassigning to varada

Comment 14

[varada]

Attachment: patch

Comment 15

[Jean-Francois Ducarroz]

r=ducarroz

Comment 16

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 17

[varada]

Marking Fixed.

Comment 18

[laurel]

Using may14 commercial trunk build: linux rh6.2, win98 and mac OS 9.0
Reopening.
Delete still has the same problem in both classic and modern skins.

Comment 19

[scottputterman]

I'm using the 5/14 build on Win 2000 and this works for me.

Comment 20

[scottputterman]

strangely enough, using the 5/15 build the delete button does not enable properly.

Comment 21

[prass]

Attachment: patch

Comment 22

[varada]

Nothing to do with outliner widget or deep down in xul as I had presumed -
someone had changed cmd_delete to be button_delete for buttons. I plead guilty
to being stupid but in my defence I was extremely tired from my illness today :-).

R=varada for this patch and reassigning to prass to finish the job.

Comment 23

[David :Bienvenu]

sr=bienvenu

Comment 24

[prass]

fixed

Comment 25

[laurel]

OK using may17 commercial trunk build: win98, linux rh6.2 and mac OS 9.0