Closed Bug 777743 Opened 12 years ago Closed 12 years ago

Report Stream Added on SetRemoteDescription Offer and Answer not on CreateAnswer

Categories

(Core :: WebRTC: Signaling, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: emannion, Assigned: emannion)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 3 obsolete files)

Extra VP8 codec negotiation added but untested.

Payload type has been propogated to vcmCreateRemoteStream
Attachment #646155 - Flags: feedback?(ethanhugg)
Attachment #646155 - Flags: feedback?(ekr)
Comment on attachment 646155 [details] [diff] [review]
OnAddStream on SetRemDesc not CreateAnswer and other nice delights

Review of attachment 646155 [details] [diff] [review]:
-----------------------------------------------------------------

Needs to be updated to apply onto the alder/default.

::: media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
@@ +3965,5 @@
>                    if (rtcpmux) {
>                      gsmsdp_set_rtcp_mux_attribute (SDP_ATTR_RTCP_MUX, media->level, sdp_p->src_sdp, TRUE);
>                    }
>  
> +                  if (TRUE == notify_stream_added) {

Mozilla style is if (notify_stream_added)

@@ +4046,5 @@
>          if (sdpmode) {
>          	/*
>          	 * Bubble the stream added event up to the PC UI
>          	 */
> +        	if (TRUE == notify_stream_added) {

Same here.

@@ +4377,5 @@
>   *
>   * Parameters:
>   *
>   * dcb_p - Pointer to the DCB whose local SDP is to be updated.
> + * force_streams_enabled - temporarly generate SDP even when no

temporarily
Attachment #646155 - Flags: feedback?(ethanhugg) → feedback+
Builds on latest default now
Attachment #646155 - Attachment is obsolete: true
Attachment #646155 - Flags: feedback?(ekr)
Fixed problem where vcmRxStartICE was getting called many times.
Attachment #647000 - Attachment is obsolete: true
Building now with the rtcp-mux patch
Attachment #647040 - Attachment is obsolete: true
QA Contact: jsmith
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: