Closed
Bug 777743
Opened 12 years ago
Closed 12 years ago
Report Stream Added on SetRemoteDescription Offer and Answer not on CreateAnswer
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: emannion, Assigned: emannion)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 3 obsolete files)
24.83 KB,
patch
|
Details | Diff | Splinter Review |
Extra VP8 codec negotiation added but untested. Payload type has been propogated to vcmCreateRemoteStream
Attachment #646155 -
Flags: feedback?(ethanhugg)
Attachment #646155 -
Flags: feedback?(ekr)
Comment 1•12 years ago
|
||
Comment on attachment 646155 [details] [diff] [review] OnAddStream on SetRemDesc not CreateAnswer and other nice delights Review of attachment 646155 [details] [diff] [review]: ----------------------------------------------------------------- Needs to be updated to apply onto the alder/default. ::: media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c @@ +3965,5 @@ > if (rtcpmux) { > gsmsdp_set_rtcp_mux_attribute (SDP_ATTR_RTCP_MUX, media->level, sdp_p->src_sdp, TRUE); > } > > + if (TRUE == notify_stream_added) { Mozilla style is if (notify_stream_added) @@ +4046,5 @@ > if (sdpmode) { > /* > * Bubble the stream added event up to the PC UI > */ > + if (TRUE == notify_stream_added) { Same here. @@ +4377,5 @@ > * > * Parameters: > * > * dcb_p - Pointer to the DCB whose local SDP is to be updated. > + * force_streams_enabled - temporarly generate SDP even when no temporarily
Attachment #646155 -
Flags: feedback?(ethanhugg) → feedback+
Assignee | ||
Comment 2•12 years ago
|
||
Builds on latest default now
Attachment #646155 -
Attachment is obsolete: true
Attachment #646155 -
Flags: feedback?(ekr)
Comment 3•12 years ago
|
||
Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/e446756a0ae8
Assignee | ||
Comment 4•12 years ago
|
||
Fixed problem where vcmRxStartICE was getting called many times.
Attachment #647000 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Building now with the rtcp-mux patch
Attachment #647040 -
Attachment is obsolete: true
Comment 6•12 years ago
|
||
Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/92452b0e960d
Updated•12 years ago
|
QA Contact: jsmith
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•