777743 - Report Stream Added on SetRemoteDescription Offer and Answer not on CreateAnswer

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[enda mannion (:emannion)]

Attachment: OnAddStream on SetRemDesc not CreateAnswer and other nice delights

Extra VP8 codec negotiation added but untested.

Payload type has been propogated to vcmCreateRemoteStream

Comment 1

[Ethan Hugg [:ehugg]]

Comment on attachment 646155 [details] [diff] [review]
OnAddStream on SetRemDesc not CreateAnswer and other nice delights

Review of attachment 646155 [details] [diff] [review]:
-----------------------------------------------------------------

Needs to be updated to apply onto the alder/default.

::: media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
@@ +3965,5 @@
>                    if (rtcpmux) {
>                      gsmsdp_set_rtcp_mux_attribute (SDP_ATTR_RTCP_MUX, media->level, sdp_p->src_sdp, TRUE);
>                    }
>  
> +                  if (TRUE == notify_stream_added) {

Mozilla style is if (notify_stream_added)

@@ +4046,5 @@
>          if (sdpmode) {
>          	/*
>          	 * Bubble the stream added event up to the PC UI
>          	 */
> +        	if (TRUE == notify_stream_added) {

Same here.

@@ +4377,5 @@
>   *
>   * Parameters:
>   *
>   * dcb_p - Pointer to the DCB whose local SDP is to be updated.
> + * force_streams_enabled - temporarly generate SDP even when no

temporarily

Comment 2

[enda mannion (:emannion)]

Attachment: OnAddStream called for SetRemDesc not CreateAnswer

Builds on latest default now

Comment 3

[Ethan Hugg [:ehugg]]

Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/e446756a0ae8

Comment 4

[enda mannion (:emannion)]

Attachment: OnAddStream called for SetRemDesc not CreateAnswer

Fixed problem where vcmRxStartICE was getting called many times.

Comment 5

[enda mannion (:emannion)]

Attachment: OnAddStream called for SetRemDesc not CreateAnswer

Building now with the rtcp-mux patch

Comment 6

[Ethan Hugg [:ehugg]]

Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/92452b0e960d