77778 - Stuttering in list of components, etc.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Terry Weissman]

Bugzilla has had a long time, very-hard-to-reproduce problem where occasionally
all the entries in the versions and components and other selection lists would
get duplicated: each component would be listed twice, etc.

Everyone knew that this was because the versioncache file was getting corrupted,
but nobody knew how.

Well, I happened to be staring at some code, and I think I found out how.

If a .cgi calls GetVersionTable() more than once and if it has been exactly one
hour since the versioncache file was last created, then this problem can result.
 The first time it gets called, it decides that the existing file is recent
enough it loads the data from the versioncache file.  The second time, the clock
has ticked over one second and so it now decides the versioncache file is
out-of-date.  So, it goes to regenerate it.  Well, all the regeneration code
assumes that the variables start out empty, so it is going to append new data to
the end of the existing data in memory from the first time it loaded.  Oops.

GetVersionTable() needs to be patched to do nothing if it has been called already.

Comment 1

[Matthew Tuck [:CodeMachine]]

*** Bug 71888 has been marked as a duplicate of this bug. ***

Comment 2

[Dave Miller [:justdave]]

We seem to be running into this a lot on b.m.o. lately...  here's hoping this 
fixes the corruptions...

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch

Comment 4

[Tara Hernandez]

r=tara

Comment 5

[Dave Miller [:justdave]]

checked in.

Comment 6

[Dave Miller [:justdave]]

*** Bug 2669 has been marked as a duplicate of this bug. ***

Comment 7

[Dave Miller [:justdave]]

Moving to Bugzilla product