777792 - Uninitialized variable in ParamTraits<nsMouseEvent>::Read

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(no longer active)]

Similar to bug 777734.

../../dist/include/IPC/nsGUIEventIPC.h:140:10: warning: variable 'exit' is used uninitialized whenever '&&' condition is false
      [-Wsometimes-uninitialized]
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:148:57: note: uninitialized use occurs here
    aResult->exit = static_cast<nsMouseEvent::exitType>(exit);
                                                        ^~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: note: remove the '&&' if its condition is always true
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: warning: variable 'exit' is used uninitialized whenever '&&' condition is false
      [-Wsometimes-uninitialized]
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:148:57: note: uninitialized use occurs here
    aResult->exit = static_cast<nsMouseEvent::exitType>(exit);
                                                        ^~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: note: remove the '&&' if its condition is always true
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: warning: variable 'exit' is used uninitialized whenever '&&' condition is false
      [-Wsometimes-uninitialized]
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:148:57: note: uninitialized use occurs here
    aResult->exit = static_cast<nsMouseEvent::exitType>(exit);
                                                        ^~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: note: remove the '&&' if its condition is always true
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: warning: variable 'exit' is used uninitialized whenever '&&' condition is false
      [-Wsometimes-uninitialized]
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:148:57: note: uninitialized use occurs here
    aResult->exit = static_cast<nsMouseEvent::exitType>(exit);
                                                        ^~~~
../../dist/include/IPC/nsGUIEventIPC.h:140:10: note: remove the '&&' if its condition is always true
    rv = ReadParam(aMsg, aIter, static_cast<nsMouseEvent_base*>(aResult)) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/IPC/nsGUIEventIPC.h:139:34: note: initialize the variable 'exit' to silence this warning
    PRUint8 reason, context, exit;
                                 ^
                                  = '\0'

Same for reason and context.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 646212 [details] [diff] [review]
Patch (v1)

r+ for the same reason, to make the warnings shut up.

Comment 3

[(no longer active)]

Landed first with the wrong bug #:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3077d21f177b

Then backed it out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b4f10c6d5e2

And relanded with the correct bug number:

https://hg.mozilla.org/integration/mozilla-inbound/rev/46ea45da584e

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/46ea45da584e