Closed
Bug 777811
Opened 12 years ago
Closed 12 years ago
Clean up getSubject() in AllPagesTab
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
|
5.02 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
https://bug586885.bugzilla.mozilla.org/attachment.cgi?id=623360 added the AwesomeBarCursorItem object to make the list a bit more OO; that is, we avoid having to use "instanceof" to determine which action to use for each item. We can do the same thing with getSubject().
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #646225 -
Flags: review?(wjohnston)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #646225 -
Flags: review?(wjohnston) → review?(mark.finkle)
|
||
Updated•12 years ago
|
Attachment #646225 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/15d0df2720e2
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/15d0df2720e2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•