If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Watcher should log more information on its current state

RESOLVED FIXED in mozilla17

Status

Testing
SUTAgent
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Trunk
mozilla17
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This would help us get information for cases where a device reboots and we're examining logs, it's also just a friendly thing to do in general (no need to look up api documentation to figure out where to put the watcher's ini file: just look at the logcat!)
Summary: Watcher should log some information about its configuration on startup → Watcher should log more information on its current state
Created attachment 646284 [details] [diff] [review]
Patch to add some logging to watcher

Here's an initial patch to the watcher to show some more logging. A small sample of what I see when I try to use it on my Panda:

I/Watcher ( 1869): Loading settings from /data/data/com.mozilla.watcher/files/watcher.ini
I/Watcher ( 1869): Pinging 192.1.1.1 after a delay of 20.0 sec, period of 5.0 sec, max number of failed attempts is 2 (if max # of failed attempts is 0, then no checking)
I/Watcher ( 1869): Pinging 192.1.1.1
I/Watcher ( 1869): Ping result was: 'You must have internet permissions to use ping.  Aborting.'
I/Watcher ( 1869): Pinging 192.1.1.1
I/Watcher ( 1869): Ping result was: 'You must have internet permissions to use ping.  Aborting.'

(note how this uncovered a bug with running the watcher on the panda!)

It would be even better if we logged reboots explicitly using some method similar to what jmaher did with sutagent, but this is a good start at making the behaviour of Watcher more debuggable.
Attachment #646284 - Flags: review?(jmaher)
Comment on attachment 646284 [details] [diff] [review]
Patch to add some logging to watcher

Review of attachment 646284 [details] [diff] [review]:
-----------------------------------------------------------------

this is good.  If we want to in the future, we could roll this into sutcommands.txt, but I don't think it is necessary.
Attachment #646284 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/aa33ec84b558
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.