Closed
Bug 777836
Opened 14 years ago
Closed 14 years ago
Watcher should log more information on its current state
Categories
(Testing Graveyard :: SUTAgent, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
4.35 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
This would help us get information for cases where a device reboots and we're examining logs, it's also just a friendly thing to do in general (no need to look up api documentation to figure out where to put the watcher's ini file: just look at the logcat!)
| Assignee | ||
Updated•14 years ago
|
Summary: Watcher should log some information about its configuration on startup → Watcher should log more information on its current state
| Assignee | ||
Comment 1•14 years ago
|
||
Here's an initial patch to the watcher to show some more logging. A small sample of what I see when I try to use it on my Panda:
I/Watcher ( 1869): Loading settings from /data/data/com.mozilla.watcher/files/watcher.ini
I/Watcher ( 1869): Pinging 192.1.1.1 after a delay of 20.0 sec, period of 5.0 sec, max number of failed attempts is 2 (if max # of failed attempts is 0, then no checking)
I/Watcher ( 1869): Pinging 192.1.1.1
I/Watcher ( 1869): Ping result was: 'You must have internet permissions to use ping. Aborting.'
I/Watcher ( 1869): Pinging 192.1.1.1
I/Watcher ( 1869): Ping result was: 'You must have internet permissions to use ping. Aborting.'
(note how this uncovered a bug with running the watcher on the panda!)
It would be even better if we logged reboots explicitly using some method similar to what jmaher did with sutagent, but this is a good start at making the behaviour of Watcher more debuggable.
Attachment #646284 -
Flags: review?(jmaher)
Comment 2•14 years ago
|
||
Comment on attachment 646284 [details] [diff] [review]
Patch to add some logging to watcher
Review of attachment 646284 [details] [diff] [review]:
-----------------------------------------------------------------
this is good. If we want to in the future, we could roll this into sutcommands.txt, but I don't think it is necessary.
Attachment #646284 -
Flags: review?(jmaher) → review+
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•