77791 - nsParserUtils::GetQuotedAttributeValue() cleanup

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

nsParserUtils::GetQuotedAttributeValue() returns NS_ERROR_FAILURE if it does not
find the attribute. It should not return an error value in that case.

Also, the second parameter is of type nsString, which means that you cannot use
NS_LITERAL_STRING in the caller, which causes a performance hit since you have
to use NS_ConvertASCIItoUCS2 which is at least two times slower than
NS_LITERAL_STRING.  Note that just changing the function signature does not
help, you will need to change the implementation to work with nsAReadableString
as well.

The fix for this bug should also include fixing the callers to use
NS_LITERAL_STRING.

Comment 1

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 2

[harishd]

This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug, or if it blocks your work in some way
 -- please attach your concern to the bug for reconsideration. 

Comment 3

[Peter Van der Beken [:peterv]]

This was fixed as part of bug 34849.