Last Comment Bug 777943 - Let WebGL getRenderbufferParameter return the WebGL format rather than re-querying the GL and tweaking
: Let WebGL getRenderbufferParameter return the WebGL format rather than re-que...
Status: RESOLVED FIXED
webgl-conformance
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Benoit Jacob [:bjacob] (mostly away)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 14:40 PDT by Benoit Jacob [:bjacob] (mostly away)
Modified: 2012-07-27 08:58 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
getrenderbufferparameter (1.76 KB, patch)
2012-07-26 14:40 PDT, Benoit Jacob [:bjacob] (mostly away)
jgilbert: review+
Details | Diff | Review

Description Benoit Jacob [:bjacob] (mostly away) 2012-07-26 14:40:19 PDT
Created attachment 646354 [details] [diff] [review]
getrenderbufferparameter

Currently getRenderbufferParameter for INTERNAL_FORMAT queries the GL and performs a tweak to map correctly GL renderbuffer formats to WebGL formats.

We should simply return the WebGL format instead, which we already know. In addition of being simpler (no tweaking needed) this works around one of the remaining driver bugs on Mac OSX 10.8 / AMD.
Comment 1 Benoit Jacob [:bjacob] (mostly away) 2012-07-26 15:14:48 PDT
https://tbpl.mozilla.org/?tree=Try&rev=eb6586091af3
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2012-07-26 17:00:43 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/e402bc9ce9cc
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-07-27 08:58:54 PDT
https://hg.mozilla.org/mozilla-central/rev/e402bc9ce9cc

Note You need to log in before you can comment on or make changes to this bug.