Let WebGL getRenderbufferParameter return the WebGL format rather than re-querying the GL and tweaking

RESOLVED FIXED in mozilla17

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: webgl-conformance)

Attachments

(1 attachment)

Created attachment 646354 [details] [diff] [review]
getrenderbufferparameter

Currently getRenderbufferParameter for INTERNAL_FORMAT queries the GL and performs a tweak to map correctly GL renderbuffer formats to WebGL formats.

We should simply return the WebGL format instead, which we already know. In addition of being simpler (no tweaking needed) this works around one of the remaining driver bugs on Mac OSX 10.8 / AMD.
Attachment #646354 - Flags: review?(jgilbert)
(Assignee)

Comment 1

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=eb6586091af3
Attachment #646354 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/e402bc9ce9cc
Assignee: nobody → bjacob
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/e402bc9ce9cc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.