Last Comment Bug 777949 - Make the editor Makefile.in's splendid
: Make the editor Makefile.in's splendid
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 14:48 PDT by :Ehsan Akhgari
Modified: 2012-07-27 08:57 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (6.81 KB, patch)
2012-07-26 14:49 PDT, :Ehsan Akhgari
khuey: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-07-26 14:48:39 PDT
I have a patch which should make the Makefile.in's in editor/ BuildSplendid-friendly!
Comment 1 :Ehsan Akhgari 2012-07-26 14:49:17 PDT
Created attachment 646358 [details] [diff] [review]
Patch (v1)
Comment 2 Gregory Szorc [:gps] 2012-07-26 15:46:13 PDT
Comment on attachment 646358 [details] [diff] [review]
Patch (v1)

Review of attachment 646358 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/txmgr/Makefile.in
@@ +18,1 @@
>  endif

We have a TEST_DIRS variable in rules.mk that is essentially:

ifdef ENABLE_TESTS
DIRS += TEST_DIRS
endif

Perhaps we should do something similar for test dirs in the tools tier? Better yet, perhaps we could just change all tests so they execute in the final tier (the tools tier)?
Comment 3 :Ehsan Akhgari 2012-07-26 17:04:55 PDT
(In reply to comment #2)
> Perhaps we should do something similar for test dirs in the tools tier? Better
> yet, perhaps we could just change all tests so they execute in the final tier
> (the tools tier)?

That makes sense to me.  You're not asking for me to do that in this bug, right?  (I don't know how to do that!)
Comment 4 Gregory Szorc [:gps] 2012-07-26 17:39:57 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> (In reply to comment #2)
> > Perhaps we should do something similar for test dirs in the tools tier? Better
> > yet, perhaps we could just change all tests so they execute in the final tier
> > (the tools tier)?
> 
> That makes sense to me.  You're not asking for me to do that in this bug,
> right?  (I don't know how to do that!)

No, I'm not asking you to do it. I'm just planting a seed in the build peers' heads :)
Comment 5 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-26 17:44:46 PDT
Comment on attachment 646358 [details] [diff] [review]
Patch (v1)

Review of attachment 646358 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/Makefile.in
@@ +11,5 @@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +MODULE           := editor
> +DIRS             := public idl txtsvc libeditor txmgr composer

Can any of these run in parallel?  Do txtsvc, libeditor, txmgr, and composer have dependencies on each other?
Comment 6 :Ehsan Akhgari 2012-07-26 19:03:59 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82321cde733

I'll try to parallelize these directories in another bug.

Note You need to log in before you can comment on or make changes to this bug.