Make the editor Makefile.in's splendid

RESOLVED FIXED in mozilla17

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I have a patch which should make the Makefile.in's in editor/ BuildSplendid-friendly!
Created attachment 646358 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #646358 - Flags: review?(khuey)

Comment 2

5 years ago
Comment on attachment 646358 [details] [diff] [review]
Patch (v1)

Review of attachment 646358 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/txmgr/Makefile.in
@@ +18,1 @@
>  endif

We have a TEST_DIRS variable in rules.mk that is essentially:

ifdef ENABLE_TESTS
DIRS += TEST_DIRS
endif

Perhaps we should do something similar for test dirs in the tools tier? Better yet, perhaps we could just change all tests so they execute in the final tier (the tools tier)?
(In reply to comment #2)
> Perhaps we should do something similar for test dirs in the tools tier? Better
> yet, perhaps we could just change all tests so they execute in the final tier
> (the tools tier)?

That makes sense to me.  You're not asking for me to do that in this bug, right?  (I don't know how to do that!)

Comment 4

5 years ago
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> (In reply to comment #2)
> > Perhaps we should do something similar for test dirs in the tools tier? Better
> > yet, perhaps we could just change all tests so they execute in the final tier
> > (the tools tier)?
> 
> That makes sense to me.  You're not asking for me to do that in this bug,
> right?  (I don't know how to do that!)

No, I'm not asking you to do it. I'm just planting a seed in the build peers' heads :)
Comment on attachment 646358 [details] [diff] [review]
Patch (v1)

Review of attachment 646358 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/Makefile.in
@@ +11,5 @@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +MODULE           := editor
> +DIRS             := public idl txtsvc libeditor txmgr composer

Can any of these run in parallel?  Do txtsvc, libeditor, txmgr, and composer have dependencies on each other?
Attachment #646358 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82321cde733

I'll try to parallelize these directories in another bug.
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/d82321cde733
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.