With CPG, AutoCompartment no longer needs to store the target object

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Happily, it also looks like removing that field may also drop us below an alignment threshold. Just in case you had a million AutoCompartments on the stack... (and I haven't pushed this to try yet, so I may be wrong anyway)

I also noticed that the global dummy_class for entering scripts' compartments is no longer used, so I nuked it.
(Assignee)

Comment 1

5 years ago
Created attachment 646365 [details] [diff] [review]
With CPG, AutoCompartment no longer needs to store the target object
Attachment #646365 - Flags: review?(luke)

Comment 2

5 years ago
Comment on attachment 646365 [details] [diff] [review]
With CPG, AutoCompartment no longer needs to store the target object

Kill all the dummies!
Attachment #646365 - Flags: review?(luke) → review+
Whiteboard: [js:t]
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/efb7823db78a
https://hg.mozilla.org/mozilla-central/rev/efb7823db78a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.