777975 - Text handles for text-selection in the AwesomeBar should be orange

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Honestly, who doesn't want more orange?

--
Nightly (07/26)
Galaxy Nexus (Android 4.1.1)

Comment 1

[Sriram Ramasubramanian [:sriram]]

The sizes of the handles are different from the stock:
https://github.com/android/platform_frameworks_base/blob/master/core/res/res/drawable-xhdpi/text_select_handle_left.png

This might affect the way it aligns.

Also, we need this too: https://github.com/android/platform_frameworks_base/blob/master/core/res/res/drawable-xhdpi/text_select_handle_middle.png

Comment 2

[:Margaret Leibovic]

We could update our handles to be the same size as the stock handles. We'd just have to make sure we update the text selection related styles appropriately. I could take care of that in a separate bug if we go that route.

Comment 3

[Aaron Train [:aaronmt]]

There are also handles and selection highlight that may be overridable in 'Edit Bookmarks' (on long-tap on an item in the view).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - Do we want this

Comment 5

[Ian Barlow (:ibarlow)]

Yes. Sorry, thought I already said yes to this...

Comment 6

[Ian Barlow (:ibarlow)]

Attachment: resized handle graphics

These are based on the image sizes that sriram linked to above.

Comment 7

[Aaron Train [:aaronmt]]

Aren't we swaying around from orange everywhere now? Maybe this is wont-fix.

Comment 8

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #7)
> Aren't we swaying around from orange everywhere now? Maybe this is wont-fix.

We already use orange handles in content, so it feels like this would provide consistency. Also I think it would do a nice job matching the highlight colors in the awesomebar.

Comment 9

[:Margaret Leibovic]

Ian, can you confirm that we still want to do this?

Comment 10

[Ian Barlow (:ibarlow)]

We sure do!

Comment 11

[:Margaret Leibovic]

Attachment: patch

I updated the graphics to use the ones ibarlow provided, but because they're larger than the current images, I had to adjust our text_selection_handle dimensions. The width/height are the width/height of the mdpi images (that's what they were before and I updated them to match the new images), and the shadow is the amount of space we need to adjust by to make the handle image line up with the edge of the selection, since there's extra empty-looking space to the side of the images. I also updated the calculation for the offset for the middle handle, since it doesn't make sense for shadow to be accounted for there (I think this isn't currently a noticeable issue because the shadow value is so small).

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60700432d0c9

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60700432d0c9