777983 - Add Marionette test for gps support

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

We can send fake position using emulator, so this should be testable using Marionette.

Comment 1

[[e-mail] [:onecyrenus]]

Kan-Ru, I think you will be able to do this following

http://mxr.mozilla.org/mozilla-central/source/dom/battery/test/marionette/test_battery.js

runEmulatorCmd("geo fix lat lon");

Comment 2

[Al Tsai [:atsai]]

Attachment: Add marionette test for b2g gps provider

Comment 3

[Al Tsai [:atsai]]

Attachment: Add marionette test for b2g gps provider

Comment 4

[Doug Turner (:dougt)]

I am trying to understand what this is really testing.  So, you can send a command to the emulator like:

geo fix 1 2

And the gonk gps provider will see a fix at 1 , 2?

Comment 5

[Al Tsai [:atsai]]

(In reply to Doug Turner (:dougt) from comment #4)
> I am trying to understand what this is really testing.  So, you can send a
> command to the emulator like:
> 
> geo fix 1 2
> 
> And the gonk gps provider will see a fix at 1 , 2?

Yes. And make sure both getCurrentPosition and watchPosition works

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Don't resolve bugs until they land on mozilla-central.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

<3

https://hg.mozilla.org/integration/mozilla-inbound/rev/50ca3a4230c8

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/50ca3a4230c8

Comment 9

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 669443 [details] [diff] [review]
Add marionette test for b2g gps provider

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: none
Testing completed (on m-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low. This only adds a testcase for testing B2G default GPS geolocation provider.
String or UUID changes made by this patch: none

Comment 10

[[e-mail] [:onecyrenus]]

Kan ru question is whether this should be in marionette or in mochitest ? 

https://github.com/geoelectric/webapi-smoke-sprint

If you feel it should be in marionette, could you explain why ? Because I spent time figuring this out for mochitest, would seem that it would be a good idea for us to understand why we wouldn't just keep this in mochitest, or for me to understand what should be in marionette vs mochitest.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Will wait for a response to the questions posed in comment 10 before assessing the approval request.

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

@dclarke This test requires marionette because it tests the specific GonkGPSGeolocationProvider component and we want to use the emulator to send fake location info. Does mochitest support that?

Comment 13

[[e-mail] [:onecyrenus]]

Yes. 
conn = mozTCPSocket.open("10.0.2.2", 5554)

Comment 14

[[e-mail] [:onecyrenus]]

then i think you do a conn.send("geo fix " + lon + " " + lat)... something like that.. but definitely doable in mochitest land.

Comment 15

[Kan-Ru Chen [:kanru] (UTC+9)]

I'm fine with either one, as long as there is a test. Marionette test was our only choice. Are you suggesting that we move to mochitest?

Comment 16

[[e-mail] [:onecyrenus]]

kan-ru, I was supposed to respond to this, but forgot. I thought I had a suggestion which was to just keep things in mochitest, but team seems to want to move things to marionette.

Comment 17

[Kan-Ru Chen [:kanru] (UTC+9)]

checkin-needed for aurora. a=akeybl

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/105f9010516d