Add Marionette test for gps support

RESOLVED FIXED in Firefox 18

Status

()

Core
Geolocation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kanru, Assigned: atsai)

Tracking

Trunk
mozilla19
All
Gonk (Firefox OS)
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
We can send fake position using emulator, so this should be testable using Marionette.
(Reporter)

Updated

5 years ago
Depends on: 797513
Kan-Ru, I think you will be able to do this following

http://mxr.mozilla.org/mozilla-central/source/dom/battery/test/marionette/test_battery.js

runEmulatorCmd("geo fix lat lon");
(Assignee)

Comment 2

5 years ago
Created attachment 669429 [details] [diff] [review]
Add marionette test for b2g gps provider
Assignee: nobody → atsai
Attachment #669429 - Flags: review?(doug.turner)
(Assignee)

Comment 3

5 years ago
Created attachment 669443 [details] [diff] [review]
Add marionette test for b2g gps provider
Attachment #669429 - Attachment is obsolete: true
Attachment #669429 - Flags: review?(doug.turner)
Attachment #669443 - Flags: review?(doug.turner)

Comment 4

5 years ago
I am trying to understand what this is really testing.  So, you can send a command to the emulator like:

geo fix 1 2

And the gonk gps provider will see a fix at 1 , 2?
(Assignee)

Comment 5

5 years ago
(In reply to Doug Turner (:dougt) from comment #4)
> I am trying to understand what this is really testing.  So, you can send a
> command to the emulator like:
> 
> geo fix 1 2
> 
> And the gonk gps provider will see a fix at 1 , 2?

Yes. And make sure both getCurrentPosition and watchPosition works

Updated

5 years ago
Attachment #669443 - Flags: review?(doug.turner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Don't resolve bugs until they land on mozilla-central.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
<3

https://hg.mozilla.org/integration/mozilla-inbound/rev/50ca3a4230c8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/50ca3a4230c8
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Component: General → Geolocation
Product: Boot2Gecko → Core
Target Milestone: --- → mozilla19
Version: unspecified → Trunk
(Reporter)

Comment 9

5 years ago
Comment on attachment 669443 [details] [diff] [review]
Add marionette test for b2g gps provider

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: none
Testing completed (on m-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low. This only adds a testcase for testing B2G default GPS geolocation provider.
String or UUID changes made by this patch: none
Attachment #669443 - Flags: approval-mozilla-aurora?
Kan ru question is whether this should be in marionette or in mochitest ? 

https://github.com/geoelectric/webapi-smoke-sprint

If you feel it should be in marionette, could you explain why ? Because I spent time figuring this out for mochitest, would seem that it would be a good idea for us to understand why we wouldn't just keep this in mochitest, or for me to understand what should be in marionette vs mochitest.
Will wait for a response to the questions posed in comment 10 before assessing the approval request.
(Reporter)

Comment 12

5 years ago
@dclarke This test requires marionette because it tests the specific GonkGPSGeolocationProvider component and we want to use the emulator to send fake location info. Does mochitest support that?
Yes. 
conn = mozTCPSocket.open("10.0.2.2", 5554)
then i think you do a conn.send("geo fix " + lon + " " + lat)... something like that.. but definitely doable in mochitest land.
(Reporter)

Comment 15

5 years ago
I'm fine with either one, as long as there is a test. Marionette test was our only choice. Are you suggesting that we move to mochitest?

Updated

5 years ago
Attachment #669443 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
kan-ru, I was supposed to respond to this, but forgot. I thought I had a suggestion which was to just keep things in mochitest, but team seems to want to move things to marionette.
(Reporter)

Comment 17

5 years ago
checkin-needed for aurora. a=akeybl
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/105f9010516d
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Flags: in-testsuite+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.