778002 - Identity should createInstance XHR, not getService it

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://mxr.mozilla.org/mozilla-central/source/toolkit/identity/Identity.jsm#257

256     // this appears to be a more successful way to get at xmlhttprequest (which supposedly will close with a window
257     let req = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"]
258                 .getService(Ci.nsIXMLHttpRequest);

This is bad because you'll get the same XHR everytime.  If some other code (say an addon) does the same thing you'll cross the streams, and you could start getting load events fired for a totally different request.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

And that would mean total protonic reversal.

Wow - thanks for catching this.  I had no idea getService returned a singleton.  But now I've found this: https://developer.mozilla.org/en/Components.classes and will update the code accordingly.

Thanks again, j.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Use createInstance to get a new, not singleton, XHR instance on each invocation

Hi, Kyle,

Is this correct?

Thanks,
j

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 646632 [details] [diff] [review]
Use createInstance to get a new, not singleton, XHR instance on each invocation

Review of attachment 646632 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f6f7358234b3