Last Comment Bug 778031 - don't XSync when already already synced
: don't XSync when already already synced
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: 13 Branch
: All Linux
: -- normal with 1 vote (vote)
: mozilla17
Assigned To: Karl Tomlinson (ni?:karlt)
:
Mentors:
Depends on:
Blocks: 687831
  Show dependency treegraph
 
Reported: 2012-07-26 19:29 PDT by Karl Tomlinson (ni?:karlt)
Modified: 2012-08-01 02:53 PDT (History)
3 users (show)
karlt: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
add FinishX to XSync less frequently and use it (9.50 KB, patch)
2012-07-26 19:39 PDT, Karl Tomlinson (ni?:karlt)
cjones.bugs: review+
Details | Diff | Review
remove unnecessary ScopedXErrorHandler::GetError interface (1.76 KB, patch)
2012-07-26 19:42 PDT, Karl Tomlinson (ni?:karlt)
cjones.bugs: review+
Details | Diff | Review

Description Karl Tomlinson (ni?:karlt) 2012-07-26 19:29:54 PDT

    
Comment 1 Karl Tomlinson (ni?:karlt) 2012-07-26 19:39:56 PDT
Created attachment 646450 [details] [diff] [review]
add FinishX to XSync less frequently and use it

This skips more syncs when there are multiple plugins active, or multiple layers with the patch for bug 687831.

I haven't changed the XSyncs where it is (almost) certain that a sync is required.  I originally had plans to make FinishX detect more situations through XFlush, and that would have possibly added unnecessary overhead, but there was no win there, so I dumped that.
Comment 2 Karl Tomlinson (ni?:karlt) 2012-07-26 19:42:09 PDT
Created attachment 646451 [details] [diff] [review]
remove unnecessary ScopedXErrorHandler::GetError interface
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-26 20:32:45 PDT
Comment on attachment 646450 [details] [diff] [review]
add FinishX to XSync less frequently and use it

It's rather surprising that Xlib doesn't do this itself, but looks good!

Note You need to log in before you can comment on or make changes to this bug.