don't XSync when already already synced

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

13 Branch
mozilla17
All
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 646450 [details] [diff] [review]
add FinishX to XSync less frequently and use it

This skips more syncs when there are multiple plugins active, or multiple layers with the patch for bug 687831.

I haven't changed the XSyncs where it is (almost) certain that a sync is required.  I originally had plans to make FinishX detect more situations through XFlush, and that would have possibly added unnecessary overhead, but there was no win there, so I dumped that.
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Attachment #646450 - Flags: review?(jones.chris.g)
(Assignee)

Comment 2

5 years ago
Created attachment 646451 [details] [diff] [review]
remove unnecessary ScopedXErrorHandler::GetError interface
Attachment #646451 - Flags: review?(jones.chris.g)
Comment on attachment 646450 [details] [diff] [review]
add FinishX to XSync less frequently and use it

It's rather surprising that Xlib doesn't do this itself, but looks good!
Attachment #646450 - Flags: review?(jones.chris.g) → review+
Attachment #646451 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=47e0b459eb76

https://hg.mozilla.org/integration/mozilla-inbound/rev/330f9bebf53f
https://hg.mozilla.org/integration/mozilla-inbound/rev/deba4b252efe
Flags: in-testsuite-
Hardware: x86_64 → All

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/330f9bebf53f
https://hg.mozilla.org/mozilla-central/rev/deba4b252efe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.