The default bug view has changed. See this FAQ.

Add missing Makefile's to allmakefiles and toolkit-makefiles.sh

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Unassigned)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 646470 [details] [diff] [review]
More allmakefile coverage, v1

There are a bunch of Makefile's missing from allmakefiles and the like.

khuey gave me verbal permission to land updates. But, I figured it's best to have bugs in case I manage to break things.

The attached patch fixes everything outside of dom/.

Try at http://tbpl.mozilla.org/?tree=Try&rev=fe7b47863623
Attachment #646470 - Flags: review?(khuey)
Presume you are using a script to find these? (I have my old [albeit slightly hacky shell script] knocking about if it is of any use. Has whitelisted makefiles that are mising but never built as part of the main build etc)
(Reporter)

Comment 2

5 years ago
Nope. Ran configure on its own then grepped the output of |make| for "creating".
Comment on attachment 646470 [details] [diff] [review]
More allmakefile coverage, v1

Review of attachment 646470 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at this.  I assume you know what you're doing.
Attachment #646470 - Flags: review?(khuey) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fca296bcac8
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/2fca296bcac8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.