Closed Bug 778042 Opened 7 years ago Closed 7 years ago

Add missing Makefile's to allmakefiles and toolkit-makefiles.sh

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: gps, Unassigned)

Details

Attachments

(1 file)

There are a bunch of Makefile's missing from allmakefiles and the like.

khuey gave me verbal permission to land updates. But, I figured it's best to have bugs in case I manage to break things.

The attached patch fixes everything outside of dom/.

Try at http://tbpl.mozilla.org/?tree=Try&rev=fe7b47863623
Attachment #646470 - Flags: review?(khuey)
Presume you are using a script to find these? (I have my old [albeit slightly hacky shell script] knocking about if it is of any use. Has whitelisted makefiles that are mising but never built as part of the main build etc)
Nope. Ran configure on its own then grepped the output of |make| for "creating".
Comment on attachment 646470 [details] [diff] [review]
More allmakefile coverage, v1

Review of attachment 646470 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at this.  I assume you know what you're doing.
Attachment #646470 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fca296bcac8
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/2fca296bcac8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.