Last Comment Bug 778042 - Add missing Makefile's to allmakefiles and toolkit-makefiles.sh
: Add missing Makefile's to allmakefiles and toolkit-makefiles.sh
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 22:14 PDT by Gregory Szorc [:gps]
Modified: 2012-07-31 06:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
More allmakefile coverage, v1 (8.26 KB, patch)
2012-07-26 22:14 PDT, Gregory Szorc [:gps]
khuey: review+
Details | Diff | Splinter Review

Description Gregory Szorc [:gps] 2012-07-26 22:14:16 PDT
Created attachment 646470 [details] [diff] [review]
More allmakefile coverage, v1

There are a bunch of Makefile's missing from allmakefiles and the like.

khuey gave me verbal permission to land updates. But, I figured it's best to have bugs in case I manage to break things.

The attached patch fixes everything outside of dom/.

Try at http://tbpl.mozilla.org/?tree=Try&rev=fe7b47863623
Comment 1 Ed Morley [:emorley] 2012-07-27 00:34:45 PDT
Presume you are using a script to find these? (I have my old [albeit slightly hacky shell script] knocking about if it is of any use. Has whitelisted makefiles that are mising but never built as part of the main build etc)
Comment 2 Gregory Szorc [:gps] 2012-07-27 00:41:41 PDT
Nope. Ran configure on its own then grepped the output of |make| for "creating".
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-30 16:02:23 PDT
Comment on attachment 646470 [details] [diff] [review]
More allmakefile coverage, v1

Review of attachment 646470 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at this.  I assume you know what you're doing.
Comment 5 Ed Morley [:emorley] 2012-07-31 06:11:46 PDT
https://hg.mozilla.org/mozilla-central/rev/2fca296bcac8

Note You need to log in before you can comment on or make changes to this bug.