778052 - Support libstagefright metadata readers

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect)

Description

[Ralph Giles (:rillian)]

libstagefright contains tag metadata parsers for most of the formats it supports.

We should export this data through nsMediaPluginReader::ReadMetadata (or whatever platform decoder interface might replace it) so it's available to web content through media.mozGetMetadata().

Comment 1

[Ralph Giles (:rillian)]

Attachment: work in progress

Current work-in-progress. This is my patch from some weeks ago, rebased against the current tree.

Comment 2

[Ralph Giles (:rillian)]

I cannot reproduce the utf-16 issue I was having with the patch on my Samsung Android 4.0.4 tablet. Perhaps it was fixed in the stagefright code. mp3 playback doesn't work on my Google Android 2.3.7 (CM7) phone, so I can't check there. In the absence of a re-occurrence I'll go ahead with the code as is. The current upstream stagefright should always be returning utf-8 strings.

Todo:

- Query more tags. We don't have 'raw' access in the sense of file-level tag names, but we can expose the ones stagefright defines.
- Add tests. We already have an mp3 example with id3 tags, but it contains no i18n.

Comment 3

[cajbir (:cajbir)]

(In reply to Ralph Giles (:rillian) from comment #2)
> mp3 playback doesn't work on my Google Android 2.3.7 (CM7) phone, so I can't
> check there.

Patches in Bug 787228 should get this working for you.

Comment 4

[Ralph Giles (:rillian)]

Thanks, Chris.

BTW, is there something I can use the conditionalize the android version we're building against? Later releases defined more metadata keys than GB does.

Comment 5

[cajbir (:cajbir)]

In media/omx-plugin MOZ_ANDROID_GB and MOZ_ANDROID_HC for gingerbread and honeycomb. If neither are set it's JB+.

Comment 6

[Ralph Giles (:rillian)]

Attachment: work in progress

Updated patch conditionalizing kKeyLocation. Thanks Chris.

This works some of the time on my ICS tablet, returning metadata, including cover art mime-type, but sometimes I get nothing, and sometimes playback itself fails.

Comment 7

[Ralph Giles (:rillian)]

I don't expect to pick this up again any time soon. Putting it up for grabs.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Closing this on the basis that we've removed libstagefright and thus no longer want to integrate parts of it.