778078 - disable glib slice allocator on systems with jemalloc in libc

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Jan Beich]

FreeBSD and NetBSD have jemalloc in libc for quite some time[1]. I think Bug 431221 is also applicable to them when not using --enable-jemalloc.

[1] FreeBSD 6.4 release, the last one with old malloc, was discontinued ~2 years ago;
    I expect NetBSD 4.x won't be far off, too

Comment 1

[Jan Beich]

Attachment: disable

Comment 2

[Jan Beich]

Comment on attachment 646500 [details] [diff] [review]
disable

tnn doesn't seem to be active

Comment 3

[Martin Husemann]

Looks good (we are about to desupport netbsd-4, which is the last release with old malloc)

Comment 4

[Jan Beich]

Comment on attachment 646500 [details] [diff] [review]
disable

Trying a person working on jemalloc3. This change is for old version, systems using 3.0.0 should probably follow bug 788955.

http://svnweb.freebsd.org/base/stable/9/lib/libc/stdlib/malloc.c
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/stdlib/jemalloc.c

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 646500 [details] [diff] [review]
disable

Review of attachment 646500 [details] [diff] [review]:
-----------------------------------------------------------------

jemalloc is not the system malloc on older FreeBSD and NetBSD, is it? It would be better to check for the right versions

Comment 6

[Martin Husemann]

For NetBSD that would be: #if __NetBSD_Version__ >= 500000000

Comment 7

[Jan Beich]

Attachment: Bug 778078 - Disable GLib slice allocator on systems with jemalloc in libc.

(In reply to Mike Hommey [:glandium] from comment #5)
> jemalloc is not the system malloc on older FreeBSD and NetBSD, is it? It
> would be better to check for the right versions

Despite bug 784029, bug 784058 and lots of other cleanups? I'd better not clutter ifdefs with versions past expirage. NetBSD 4.x is yet to be desupported, so I've added version check for it.

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cc688fe4e5d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4cc688fe4e5d