The default bug view has changed. See this FAQ.

java.lang.NullPointerException: at org.mozilla.gecko.sync.CommandProcessor$Command.getArgsList(CommandProcessor.java)

RESOLVED FIXED in Firefox 16

Status

Android Background Services
Android Sync
P2
critical
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Scoobidiver (away), Assigned: nalexander)

Tracking

({crash})

unspecified
mozilla17
ARM
Android
crash

Firefox Tracking Flags

(firefox16 fixed)

Details

(Whiteboard: [native-crash][sync], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
There's one crash in 16.0a2/20120726: bp-66a39aa8-1e80-42e1-bfb7-9af262120726.

java.lang.NullPointerException
	at org.mozilla.gecko.sync.CommandProcessor$Command.getArgsList(CommandProcessor.java:72)
	at org.mozilla.gecko.sync.CommandProcessor.sendCommand(CommandProcessor.java:191)
	at org.mozilla.gecko.sync.CommandProcessor.sendURIToClientForDisplay(CommandProcessor.java:163)
	at org.mozilla.gecko.sync.setup.activities.SendTabActivity$3.run(SendTabActivity.java:137)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.sync.CommandProcessor%24Command.getArgsList%28CommandProcessor.java%29
(Reporter)

Comment 1

5 years ago
and now two crashes in 17.0a1/20120726.
It might be a regression from bug 774233.
Component: General → Android Sync
Keywords: regression
Product: Firefox for Android → Mozilla Services
Version: Firefox 16 → unspecified
Looks like this can only happen when getJSONArrayFromCursor returns null. The other call sites don't result in a null `args` array inside `Command`.

No chance of this being a regression from that bug. It's just dependent on input data.
Group: mozilla-corporation-confidential
Keywords: regression
Priority: -- → P2
Group: mozilla-corporation-confidential
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b7ed8e5d616
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
Created attachment 647278 [details] [diff] [review]
Proposed patch for Aurora. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  Since original landing of command send code.
 
User impact if declined: 
  Low rate of crashes.

Testing completed (on m-c, etc.): 
  Landed on m-i now; not really QA-able, but we'll see if anything bad happens.

Risk to taking this patch (and alternatives if risky): 
  Minimal.

String or UUID changes made by this patch: 
  I stripped out the string change made in the m-i landing, so this is code only.
Attachment #647278 - Flags: review+
Attachment #647278 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6b7ed8e5d616
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 647278 [details] [diff] [review]
Proposed patch for Aurora. v1

No strings, no problems. Approving.
Attachment #647278 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/cbf944c8b6fc
status-firefox16: --- → fixed
Component: Android Sync → Android Sync
Product: Mozilla Services → Android Background Services
You need to log in before you can comment on or make changes to this bug.