778106 - nsPrintProgress::CloseProgressDialog uses bool as nsresult

Status: REOPENED

(Toolkit :: Printing, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

return OnStateChange(nsnull, nsnull, nsIWebProgressListener::STATE_STOP, forceClose);

forceClose is a bool, but the fourth param of OnStateChange is an nsresult.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

The Mac and Windows versions also do this.

Comment 2

[Benjamin Smedberg]

This bug is filed in a bugzilla component related to pre-Firefox code which no longer exists. I believe it is no longer relevant and I am therefore closing it INCOMPLETE.

If you believe that this bug is still valid and needs to be fixed, please reopen it and move it to the Toolkit:Startup and Profile System product/component.

Comment 3

[Nicholas Nethercote [inactive]]

embedding/components/printingui/unixshared/nsPrintProgress.cpp specifically mentions this bug in a comment:

> NS_IMETHODIMP nsPrintProgress::CloseProgressDialog(bool forceClose)
> {
>   m_closeProgress = true;
>   // XXX Invalid cast of bool to nsresult (bug 778106)
>   return OnStateChange(nullptr, nullptr, nsIWebProgressListener::STATE_STOP,
>                        (nsresult)forceClose);
> }

So the problem still exists.

I've the right Bugzilla component for that file; please correct it if it's wrong.

Comment 4

[Benjamin Smedberg]

Mass change of bugs in the "Embedding: GRE Core" component in preparation for archiving it. I believe that these are no longer relevant; but if they are, they should be reopened and moved into a component relevant to the code in question.

Comment 5

[Andrew McCreight [:mccr8]]

This code was removed for OSX in bug 1134891. The problem still exists for Windows and Unix.