Last Comment Bug 778181 - async protocol proxy service fails to record resolve flags
: async protocol proxy service fails to record resolve flags
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: 16 Branch
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on:
Blocks: 769764 778201
  Show dependency treegraph
 
Reported: 2012-07-27 09:49 PDT by Patrick McManus [:mcmanus]
Modified: 2012-07-28 18:34 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 0 (997 bytes, patch)
2012-07-27 09:52 PDT, Patrick McManus [:mcmanus]
cbiesinger: review+
Details | Diff | Review

Description Patrick McManus [:mcmanus] 2012-07-27 09:49:17 PDT
The returned Proxy info from nsIProtocolProxyService contains the flags used to perform the proxy resolution. The async version of that resolution wasn't recording the flags correctly.

We almost never actually use the async resolution (which I'm fixing in another bug) and the only thing the flags are really important to are websockets. so it doesn't seem to be a problem for any in-tree code, but its a problem for the code I'm writing.
Comment 1 Patrick McManus [:mcmanus] 2012-07-27 09:52:44 PDT
Created attachment 646613 [details] [diff] [review]
patch 0
Comment 2 Christian :Biesinger (don't email me, ping me on IRC) 2012-07-27 13:32:13 PDT
Comment on attachment 646613 [details] [diff] [review]
patch 0

heh. "oops"
Comment 3 Patrick McManus [:mcmanus] 2012-07-27 18:42:31 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f7ccabe2e5d
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:34:30 PDT
https://hg.mozilla.org/mozilla-central/rev/7f7ccabe2e5d

Note You need to log in before you can comment on or make changes to this bug.