Last Comment Bug 778195 - DrawTargetCairo.cpp:764: error: 'memcpy' was not declared in this scope
: DrawTargetCairo.cpp:764: error: 'memcpy' was not declared in this scope
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 764125
  Show dependency treegraph
 
Reported: 2012-07-27 10:05 PDT by Oleg Romashin (:romaxa)
Modified: 2012-08-02 08:31 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add string.h to cover memcpy include (683 bytes, patch)
2012-07-27 10:08 PDT, Oleg Romashin (:romaxa)
jmuizelaar: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-07-27 10:05:58 PDT
I guess string.h is missing for memcpy...
Comment 1 Oleg Romashin (:romaxa) 2012-07-27 10:08:06 PDT
Created attachment 646616 [details] [diff] [review]
Add string.h to cover memcpy include
Comment 2 Jeff Muizelaar [:jrmuizel] 2012-07-27 10:21:06 PDT
Comment on attachment 646616 [details] [diff] [review]
Add string.h to cover memcpy include

Please put <string.h> above the local includes
Comment 3 Nick Cameron [:nrc] 2012-07-27 13:38:45 PDT
Thanks for fixing this. Could you give more details about the error, in particular which platform it showed up on? And why this wasn't caught by our build bots? Thanks!
Comment 4 Nick Cameron [:nrc] 2012-07-27 14:19:15 PDT
Also, I know we have problems including some of the standard libraries on mac, does that include string.h?
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-27 14:55:37 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/74c9c20b284a

Romaxa, please make sure that qnew = -U is set in your .hgrc [defaults] section.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:35:47 PDT
https://hg.mozilla.org/mozilla-central/rev/74c9c20b284a
Comment 7 :Ms2ger 2012-08-02 02:35:50 PDT
And please address review comments...
Comment 8 Oleg Romashin (:romaxa) 2012-08-02 08:31:35 PDT
(In reply to Nick Cameron [:nrc] from comment #3)
> Thanks for fixing this. Could you give more details about the error, in
> particular which platform it showed up on? And why this wasn't caught by our
> build bots? Thanks!

For me it fails to build on Maemo/Meego and ubuntu arm oneiric (linux)

Note You need to log in before you can comment on or make changes to this bug.