Last Comment Bug 778202 - Filter out -pedantic for the Skia subdirectory
: Filter out -pedantic for the Skia subdirectory
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: George Wright (:gw280) (:gwright)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-27 10:32 PDT by George Wright (:gw280) (:gwright)
Modified: 2012-07-28 18:37 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Bug 778202 - Filter out -pedantic for the Skia subdirectory (1.14 KB, patch)
2012-07-27 10:47 PDT, George Wright (:gw280) (:gwright)
jmuizelaar: review+
Details | Diff | Splinter Review

Description George Wright (:gw280) (:gwright) 2012-07-27 10:32:15 PDT
Skia doesn't like building with -pedantic. Rather than us fixing all their enums every time, we should just turn off -pedantic.
Comment 1 George Wright (:gw280) (:gwright) 2012-07-27 10:47:06 PDT
Created attachment 646627 [details] [diff] [review]
Bug 778202 - Filter out -pedantic for the Skia subdirectory
Comment 2 Jeff Muizelaar [:jrmuizel] 2012-07-27 10:49:32 PDT
Comment on attachment 646627 [details] [diff] [review]
Bug 778202 - Filter out -pedantic for the Skia subdirectory

Review of attachment 646627 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.
Comment 3 George Wright (:gw280) (:gwright) 2012-07-27 11:58:25 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c42a830cdb90
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:37:59 PDT
https://hg.mozilla.org/mozilla-central/rev/c42a830cdb90

Note You need to log in before you can comment on or make changes to this bug.