778213 - error: TEST FAILED: test-xhr.testResponseHeaders (failure)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

error: TEST FAILED: test-xhr.testResponseHeaders (failure)
error: fail: XHR's headers are valid ("Content-Type: text/plain\r\n" != "Content-Type: text/plain\n")
info: Traceback (most recent call last):
  File "resource://2fac4b91-34cf-493c-a315-0702e1623235-at-jetpack/api-utils/lib/xhr.js", line 121, in null
    self._orsc.apply(self, arguments);
  File "resource://2fac4b91-34cf-493c-a315-0702e1623235-at-jetpack/api-utils/tests/test-xhr.js", line 62, in null
    "XHR's headers are valid");
  File "resource://2fac4b91-34cf-493c-a315-0702e1623235-at-jetpack/api-utils/lib/unit-test.js", line 164, in assertEqual
    this.fail(message);
  File "resource://2fac4b91-34cf-493c-a315-0702e1623235-at-jetpack/api-utils/lib/unit-test.js", line 71, in fail
    this.console.trace();

This started showing up after Will pushed bug 754111, which looks to me like a docs-only change...

All m-c test runs are now orange from this.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like this was a change on Firefox's side.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Link to pull request 514

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 646664 [details]
Link to pull request 514

Can you then push a new changeset in jetpack-location.txt?
There is many bugs being fixed on master and still failing on m-c tree.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can do, though it probably won't be until later today at the earliest.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ac8c41c91cdbd65df00c5e30059c7d71773b1213
Fix bug 778213 by changing the expected headers

https://github.com/mozilla/addon-sdk/commit/12922dab9c916e132aecb40ea35f5432087bf722
Merge pull request #514 from KWierso/bug778213

Fix bug 778213 by changing the expected xhr headers

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Alexandre Poirot (:ochameau) from comment #3)
> There is many bugs being fixed on master and still failing on m-c tree.

http://hg.mozilla.org/integration/mozilla-inbound/rev/9448db2a1708

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Not quite sure how it reset the status/resolutions...