778263 - JavaScript Error: "Error selecting word: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISelectionController.wordMove]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://b

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Aaron Train [:aaronmt]]

E/GeckoConsole(10402): [JavaScript Error: "Error selecting word: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISelectionController.wordMove]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/browser.js :: sh_startSelection :: line 1666"  data: no]" {file: "chrome://browser/content/browser.js" line: 1672}]

Comment 1

[Aaron Train [:aaronmt]]

I've seen this one in my log before when using text-selection on pages. You can reproduce this by long-tap holding in content on about:logo.

Comment 2

[:Margaret Leibovic]

Hm, this is an error we're catching ourselves, so it shouldn't lead to other failures, but I can look into why this is happening.

Also, I just noticed that we don't properly clean up after ourselves if we bail in startSelection. We should fix that.

Comment 3

[:Margaret Leibovic]

Attachment: patch

Logging this error is pretty useless, but we should make sure we clean up after ourselves if we're bailing in startSelection. This patch takes care of that.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7047de4a90f2

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7047de4a90f2

Comment 6

[Aaron Train [:aaronmt]]

Channel nomination?

Comment 7

[:Margaret Leibovic]

Comment on attachment 649712 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 695173 (text selection)
User impact if declined: logging a useless error isn't really a big deal, but without cleaning up properly, we can fail to remove the pagehide listener, which may cause issues
Testing completed (on m-c, etc.): landed on m-c 8/8
Risk to taking this patch (and alternatives if risky): low-risk, adds code to clean up state of SelectionHandler when we fail to start a selection
String or UUID changes made by this patch: n/a

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 649712 [details] [diff] [review]
patch

Small patch, low risk, wouldn't normally be a candidate for uplift but it's good to clean up the unused errors so approving for branches.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/824121cfc9ad
https://hg.mozilla.org/releases/mozilla-beta/rev/beb43bf67781