778301 - Remove old change for llvm.org/pr11003

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: remove it

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 646717 [details] [diff] [review]
remove it

I am testing and benchmarking it, but I think review can go in parallel.

Comment 2

[(no longer active)]

Which clang version was this fixed in?  I have another piece of code in Gecko which used to hit an LLVM bug which has since been fixed.  I wonder what our policy for keeping the code buildable with older clang versions should be...

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

It was fixed in r141137, from Oct 4, 2011. The fix in included clang 3.0 and 3.1. It is also in apple's xcode 4.4 (not sure about older versions).

I think on OS X we can build with clang >= 3.0, but I am not sure.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The talos runs are fine:

http://bit.ly/MRVkoD

I will check it in.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0dbf799a2371