Created attachment 646717 [details] [diff] [review]
Comment on attachment 646717 [details] [diff] [review]
I am testing and benchmarking it, but I think review can go in parallel.
Which clang version was this fixed in? I have another piece of code in Gecko which used to hit an LLVM bug which has since been fixed. I wonder what our policy for keeping the code buildable with older clang versions should be...
It was fixed in r141137, from Oct 4, 2011. The fix in included clang 3.0 and 3.1. It is also in apple's xcode 4.4 (not sure about older versions).
I think on OS X we can build with clang >= 3.0, but I am not sure.
The talos runs are fine:
I will check it in.