Remove old change for llvm.org/pr11003

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 646717 [details] [diff] [review]
remove it
Comment on attachment 646717 [details] [diff] [review]
remove it

I am testing and benchmarking it, but I think review can go in parallel.
Attachment #646717 - Flags: review?(luke)
Assignee: general → respindola
Status: NEW → ASSIGNED
Which clang version was this fixed in?  I have another piece of code in Gecko which used to hit an LLVM bug which has since been fixed.  I wonder what our policy for keeping the code buildable with older clang versions should be...

Updated

5 years ago
Attachment #646717 - Attachment is patch: true
Attachment #646717 - Flags: review?(luke) → review+
It was fixed in r141137, from Oct 4, 2011. The fix in included clang 3.0 and 3.1. It is also in apple's xcode 4.4 (not sure about older versions).

I think on OS X we can build with clang >= 3.0, but I am not sure.
The talos runs are fine:

http://bit.ly/MRVkoD

I will check it in.
https://hg.mozilla.org/mozilla-central/rev/0dbf799a2371
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.