Last Comment Bug 778383 - jstest: Use an options list to pass around extra args
: jstest: Use an options list to pass around extra args
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Terrence Cole [:terrence]
: general
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 746836 745251
  Show dependency treegraph
 
Reported: 2012-07-27 18:46 PDT by Terrence Cole [:terrence]
Modified: 2012-08-04 11:19 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (10.55 KB, patch)
2012-07-27 18:46 PDT, Terrence Cole [:terrence]
dmandelin: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2012-07-27 18:46:15 PDT
Created attachment 646792 [details] [diff] [review]
v0

Currently the only extra arg we need is for debugMode, so we just tack a -d onto the command before we execute it.  When we support |jit-test| and --jitflags, we are going to need many more of these, so we should store them in an options list like jit-tests does.
Comment 1 Ed Morley [:emorley] 2012-07-31 09:44:53 PDT
Push backed out for bustage:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a07ce25de7d
Comment 3 Ed Morley [:emorley] 2012-08-04 11:19:54 PDT
https://hg.mozilla.org/mozilla-central/rev/a3a94eb254c8

Note You need to log in before you can comment on or make changes to this bug.