Closed
Bug 778392
Opened 12 years ago
Closed 12 years ago
Use handleEvent() for BrowserOnClick
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: tetsuharu, Assigned: tetsuharu)
Details
Attachments
(2 files)
14.10 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
12.23 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Use handleEvent() for BrowserOnClick(). If we use handleEvent(), BrowserOnClick will be clearly.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → saneyuki.s.snyk
Assignee | ||
Updated•12 years ago
|
Component: Developer Tools → General
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #646826 -
Flags: review?(josh)
Comment 2•12 years ago
|
||
Comment on attachment 646826 [details] [diff] [review] patch I am not a browser peer, so I'm going to randomly select Felipe.
Attachment #646826 -
Flags: review?(josh) → review?(felipc)
Comment 3•12 years ago
|
||
Comment on attachment 646826 [details] [diff] [review] patch Review of attachment 646826 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Ohzeki, this is some great clean-up. If you could please update the patch with the style nits below fixed (and the `safebrowsing` change) I'll land it. ::: browser/base/content/browser.js @@ +2528,5 @@ > Components.utils.reportError("Couldn't get ssl_override pref: " + e); > } > > window.openDialog('chrome://pippki/content/exceptionDialog.xul', > + '','chrome,centerscreen,modal', params); this change (here and elsewhere) to the indentation style is incorrect. Multiple line of parameters should all be indented past the opening parens, like it was before @@ +2600,5 @@ > + Ci.nsIPermissionManager.EXPIRE_SESSION); > + > + let buttons = [{ > + label: gNavigatorBundle.getString("safebrowsing.getMeOutOfHereButton.label"), > + accessKey: gNavigatorBundle.getString("safebrowsing.getMeOutOfHereButton.accessKey"), broken indent @@ +2611,5 @@ > + buttons[1] = { > + label: gNavigatorBundle.getString("safebrowsing.notAnAttackButton.label"), > + accessKey: gNavigatorBundle.getString("safebrowsing.notAnAttackButton.accessKey"), > + callback: function() { > + openUILinkIn(safebrowsing.getReportURL('MalwareError'), 'tab'); note: `safebrowsing` seem to have changed recently to become gSafeBrowsing (changed in http://hg.mozilla.org/mozilla-central/rev/3b312c31d1cd) @@ +2757,5 @@ > _printPreviewTab: null, > _tabBeforePrintPreview: null, > > getPrintPreviewBrowser: function () { > + if (!this._printPreviewTab) { unrelated change @@ +6113,5 @@ > warnAboutClosingTabs = true; > + // If the current window is not in private browsing mode we don't need to > + // look for other pb windows, we can leave the loop when finding the > + // first non-popup window. If however the current window is in private > + // browsing mode then we need at least one other pb and one non-popup unrelated change
Attachment #646826 -
Flags: review?(felipc) → review+
Comment 5•12 years ago
|
||
Comment on attachment 647426 [details] [diff] [review] patch ver.2 Thank you!
Attachment #647426 -
Flags: review?(felipc) → review+
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf51689ab43e
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 17
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf51689ab43e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•