778425 - Unable to view crash queries with a signature containing ++

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Scoobidiver (away)]

There are no crash reports viewable in https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=1&range_unit=weeks&query_search=signature&query_type=contains&query=libstdc&reason=&build_id=&process_type=any&hang_type=any&do_query=1.

It used to work. See bug 684863.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/757

The "+" symbol is a special one in the middleware, and was used as a separator for lists. It is now double-encoded in signatures to make sure that we don't break it. 

Steps to QA
-----------

1. Go to advanced search and search for crashes in FennecAndroid with signature containing "libstdc";
2. Click one of the signatures to go to report/list;
3. Verify that you get results and numbers are matching those from search;
4. Verify that each tab has data;
5. Verify that report/list is not broken for other signatures (use topcrashers for example);
6. Enjoy a little M&M's.

Comment 3

[Scoobidiver (away)]

Is it planned to land?

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Yes, in release 19 which will come one week after we ship the special mobeta release (18). No date though as 18 will be release "when it's ready". https://wiki.mozilla.org/Socorro:Releases will be updated when we have release dates.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/cc4114924d4e82047c60531b10bb2e7751d254bc
Fixes bug 778425 - Double-encode pluses in signature before HTTP GET requests.

https://github.com/mozilla/socorro/commit/a09451d5d04b82370df917a0f3575d163498fbbb
Merge pull request #764 from AdrianGaudebert/778425-fix-plus-in-signature

Fixes bug 778425 - Double-encode pluses in signature before HTTP GET req...

Comment 6

[Matt Brandt [:mbrandt]]

QA verified on stage -- thanks Adrian.

The results in comment 0 return the expected results:

https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=1&range_unit=weeks&query_search=signature&query_type=contains&query=libstdc&reason=&build_id=&process_type=any&hang_type=any&do_query=1

https://crash-stats.allizom.org/report/list?product=FennecAndroid&query_search=signature&query_type=contains&query=libstdc&reason_type=contains&date=09%2F14%2F2012%2022%3A22%3A05&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=libstdc%2B%2B.so%400x9cd

report/list for appears to return valid results for other products (comment 1) as well as the data in the other tabs containing results.