Created attachment 646892 [details] [diff] [review]
Part 1: Remove unused and redundant import statements.
Created attachment 646894 [details] [diff] [review]
Part 2: Replace wildcard import statements with fully-qualified names, as per Google's style guide for Android Java code. This makes tracking dependencies and finding unused import statements easier.
I have a patch part 3 that cleans up our haphazard ordering of import statements, but I am waiting for feedback from m.d.p.m. re the correct order.
Comment on attachment 646892 [details] [diff] [review]
Are you using a tool to help with this or just eye-balling it? Tools like PMD and FindBugs will find this bad imports too.
(In reply to Mark Finkle (:mfinkle) from comment #4)
> Are you using a tool to help with this or just eye-balling it? Tools like
> PMD and FindBugs will find this bad imports too.
I'm using Checkstyle: http://checkstyle.sourceforge.net/
Created attachment 647681 [details] [diff] [review]
Part 3: Standardize order of import statements from most project-specific to least:
1. Project-specific imports: org.mozilla
2. Third-party libraries: com, net, org
3. System libraries: android
4. Language features: java
I have an opinion on the order of the imports (most-to-least or least-to-most), but I think any standard is better than none. On m.d.p.m., kats concurred that the most-to-least order was reasonable and no one voiced any other opinions or opposition.
Landed patch 3/3: