Text of 'Your tabs from last time' entries on about:home is not centered vertically

VERIFIED FIXED in Firefox 17

Status

()

Firefox for Android
Theme and Visual Design
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: pretzer, Assigned: mcomella)

Tracking

Trunk
Firefox 17
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox14 unaffected, firefox15 affected, firefox16 affected, firefox17 verified)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 646909 [details]
Screenshot of the issue

The text of entries in the 'Your tabs from last time' category on about:home is not centered vertically. It is sitting slightly too high (see screenshot) and is therefore not aligned with the favicon next to it.
Assignee: nobody → michael.l.comella
status-firefox14: --- → unaffected
status-firefox15: --- → affected
status-firefox16: --- → affected
status-firefox17: --- → affected
Created attachment 647003 [details] [diff] [review]
Patch

The text is now more centered. The text still looks a little too high (in my opinion) but this is due to the nature of font than anything else. I opted to keep this as a simpler solution than to align the font to a pixel-perfect degree. Let me know if you want this changed.
Attachment #647003 - Flags: review?(sriram)
Created attachment 647004 [details]
Screenshot after patch
Status: NEW → ASSIGNED
Comment on attachment 647003 [details] [diff] [review]
Patch

Review of attachment 647003 [details] [diff] [review]:
-----------------------------------------------------------------

The idea of using RelativeLayout was to reduce that one little LinearLayout in each row.
This layout is very similar to: https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/resources/layout/awesomebar_row.xml, except for the font-sizes.
Please use a 2dp marginTop for title, and it should work fine.
Attachment #647003 - Flags: review?(sriram) → review-
Created attachment 647422 [details] [diff] [review]
Patch v2
Attachment #647003 - Attachment is obsolete: true
Attachment #647422 - Flags: review?(sriram)
Created attachment 647423 [details]
Screenshot after patch v2
Attachment #647004 - Attachment is obsolete: true
Created attachment 647425 [details]
Screenshot after patch v2 with "Huge" font size

Note that after this patch, a font size of "Huge" overflows the container.
Comment on attachment 647422 [details] [diff] [review]
Patch v2

Review of attachment 647422 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #647422 - Flags: review?(sriram) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d996fd1c80c
Flags: in-testsuite-
Keywords: checkin-needed

Comment 9

6 years ago
https://hg.mozilla.org/mozilla-central/rev/6d996fd1c80c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17

Updated

6 years ago
status-firefox17: affected → ---

Updated

6 years ago
Status: RESOLVED → VERIFIED
status-firefox15: affected → verified
status-firefox16: affected → verified
status-firefox17: --- → verified

Comment 10

6 years ago
How can it be fixed in branches where the patch hasn't landed?
(In reply to Scoobidiver from comment #10)
> How can it be fixed in branches where the patch hasn't landed?

Meant for another bug, thanks.
status-firefox15: verified → affected
status-firefox16: verified → affected
You need to log in before you can comment on or make changes to this bug.