778491 - Text of 'Your tabs from last time' entries on about:home is not centered vertically

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Peter Retzer (:pretzer)]

Attachment: Screenshot of the issue

The text of entries in the 'Your tabs from last time' category on about:home is not centered vertically. It is sitting slightly too high (see screenshot) and is therefore not aligned with the favicon next to it.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

The text is now more centered. The text still looks a little too high (in my opinion) but this is due to the nature of font than anything else. I opted to keep this as a simpler solution than to align the font to a pixel-perfect degree. Let me know if you want this changed.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot after patch

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 647003 [details] [diff] [review]
Patch

Review of attachment 647003 [details] [diff] [review]:
-----------------------------------------------------------------

The idea of using RelativeLayout was to reduce that one little LinearLayout in each row.
This layout is very similar to: https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/resources/layout/awesomebar_row.xml, except for the font-sizes.
Please use a 2dp marginTop for title, and it should work fine.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch v2

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot after patch v2

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot after patch v2 with "Huge" font size

Note that after this patch, a font size of "Huge" overflows the container.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 647422 [details] [diff] [review]
Patch v2

Review of attachment 647422 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d996fd1c80c

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6d996fd1c80c

Comment 10

[Scoobidiver (away)]

How can it be fixed in branches where the patch hasn't landed?

Comment 11

[Aaron Train [:aaronmt]]

(In reply to Scoobidiver from comment #10)
> How can it be fixed in branches where the patch hasn't landed?

Meant for another bug, thanks.