pymake APIs for inspecting expansions and functions

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pymake])

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 646918 [details] [diff] [review]
Part 1: Add new Expansion APIs

As part of bug 769414, I want to add some basic APIs to pymake expansions and functions.

The changes in the patches is mostly non-invasive. The only change that impacts existing flow is I made a common base class for StringExpansion and Expansion: BaseExpansion. On this, I define a common interface. Currently, that interface adds some new functionality around querying an expansion instance. These are mostly helper functions that will be used for code that will come later in bug 769414.

The patches are applied after the one in bug 769976. I don't believe it requires any functionality from that patch. I can rebase if requested. But, I'd prefer to land bug 769976 first.
Attachment #646918 - Flags: review?(khuey)
(Assignee)

Comment 1

5 years ago
Created attachment 646919 [details] [diff] [review]
Part 2: Add new Function APIs; round out Expansion APIs, v1
Attachment #646919 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Whiteboard: [pymake]
(Assignee)

Comment 2

5 years ago
Created attachment 646923 [details] [diff] [review]
Part 1: Add new Expansion APIs, v2

Removed the leading "get_" from method names per style advice.
Attachment #646918 - Attachment is obsolete: true
Attachment #646918 - Flags: review?(khuey)
Attachment #646923 - Flags: review?(khuey)
(Assignee)

Comment 3

5 years ago
Created attachment 646924 [details] [diff] [review]
Part 2: Add new Function APIs; round out Expansion APIs, v2

Removed "get_" from method names. Included missing test file.
Attachment #646919 - Attachment is obsolete: true
Attachment #646919 - Flags: review?(khuey)
Attachment #646924 - Flags: review?(khuey)
Comment on attachment 646923 [details] [diff] [review]
Part 1: Add new Expansion APIs, v2

Review of attachment 646923 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I don't really have time to review this.  Let's just land it.
Attachment #646923 - Flags: review?(khuey)
Comment on attachment 646924 [details] [diff] [review]
Part 2: Add new Function APIs; round out Expansion APIs, v2

Review of attachment 646924 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I don't really have time to review this.  Let's just land it.
Attachment #646924 - Flags: review?(khuey)
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e28e6b21a06
https://hg.mozilla.org/integration/mozilla-inbound/rev/89ea9764f9e9

https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/7f59c27d4ad9
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/368af0ee4aa9
Assignee: nobody → gps
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7e28e6b21a06
https://hg.mozilla.org/mozilla-central/rev/89ea9764f9e9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.