778495 - pymake APIs for inspecting expansions and functions

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Part 1: Add new Expansion APIs

As part of bug 769414, I want to add some basic APIs to pymake expansions and functions.

The changes in the patches is mostly non-invasive. The only change that impacts existing flow is I made a common base class for StringExpansion and Expansion: BaseExpansion. On this, I define a common interface. Currently, that interface adds some new functionality around querying an expansion instance. These are mostly helper functions that will be used for code that will come later in bug 769414.

The patches are applied after the one in bug 769976. I don't believe it requires any functionality from that patch. I can rebase if requested. But, I'd prefer to land bug 769976 first.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Part 2: Add new Function APIs; round out Expansion APIs, v1

Comment 2

[Gregory Szorc [:gps]]

Attachment: Part 1: Add new Expansion APIs, v2

Removed the leading "get_" from method names per style advice.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Part 2: Add new Function APIs; round out Expansion APIs, v2

Removed "get_" from method names. Included missing test file.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 646923 [details] [diff] [review]
Part 1: Add new Expansion APIs, v2

Review of attachment 646923 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I don't really have time to review this.  Let's just land it.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 646924 [details] [diff] [review]
Part 2: Add new Function APIs; round out Expansion APIs, v2

Review of attachment 646924 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I don't really have time to review this.  Let's just land it.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e28e6b21a06
https://hg.mozilla.org/integration/mozilla-inbound/rev/89ea9764f9e9

https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/7f59c27d4ad9
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/368af0ee4aa9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7e28e6b21a06
https://hg.mozilla.org/mozilla-central/rev/89ea9764f9e9