Closed Bug 778495 Opened 8 years ago Closed 8 years ago

pymake APIs for inspecting expansions and functions

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: gps, Assigned: gps)

References

Details

(Whiteboard: [pymake])

Attachments

(2 files, 2 obsolete files)

Attached patch Part 1: Add new Expansion APIs (obsolete) — Splinter Review
As part of bug 769414, I want to add some basic APIs to pymake expansions and functions.

The changes in the patches is mostly non-invasive. The only change that impacts existing flow is I made a common base class for StringExpansion and Expansion: BaseExpansion. On this, I define a common interface. Currently, that interface adds some new functionality around querying an expansion instance. These are mostly helper functions that will be used for code that will come later in bug 769414.

The patches are applied after the one in bug 769976. I don't believe it requires any functionality from that patch. I can rebase if requested. But, I'd prefer to land bug 769976 first.
Attachment #646918 - Flags: review?(khuey)
Attachment #646919 - Flags: review?(khuey)
Whiteboard: [pymake]
Removed the leading "get_" from method names per style advice.
Attachment #646918 - Attachment is obsolete: true
Attachment #646918 - Flags: review?(khuey)
Attachment #646923 - Flags: review?(khuey)
Removed "get_" from method names. Included missing test file.
Attachment #646919 - Attachment is obsolete: true
Attachment #646919 - Flags: review?(khuey)
Attachment #646924 - Flags: review?(khuey)
Comment on attachment 646923 [details] [diff] [review]
Part 1: Add new Expansion APIs, v2

Review of attachment 646923 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I don't really have time to review this.  Let's just land it.
Attachment #646923 - Flags: review?(khuey)
Comment on attachment 646924 [details] [diff] [review]
Part 2: Add new Function APIs; round out Expansion APIs, v2

Review of attachment 646924 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I don't really have time to review this.  Let's just land it.
Attachment #646924 - Flags: review?(khuey)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.