Closed
Bug 778501
Opened 12 years ago
Closed 12 years ago
Clean up nsPresContext
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(4 files, 1 obsolete file)
2.74 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
3.50 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
9.38 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
4.49 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #646932 -
Attachment is obsolete: true
Attachment #646932 -
Flags: review?(roc)
Attachment #646933 -
Flags: review?(roc)
Attachment #646929 -
Flags: review?(roc) → review+
Attachment #646930 -
Flags: review?(roc) → review+
Comment on attachment 646933 [details] [diff] [review] Part 3: Clean up includes Review of attachment 646933 [details] [diff] [review]: ----------------------------------------------------------------- r+ with that ::: layout/base/nsPresContext.cpp @@ +1547,5 @@ > +#ifdef _IMPL_NS_LAYOUT > + return BidiEnabledInternal(); > +#else > + return BidiEnabledExternal(); > +#endif _IMPL_NS_LAYOUT is always defined in this file, so this defeats the whole point of BidiEnabledExternal. I think you should keep BidiEnabled as it was, inline in nsPresContext.h.
Attachment #646933 -
Flags: review?(roc) → review+
Attachment #647039 -
Flags: review?(roc) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/23460a801bb6 https://hg.mozilla.org/integration/mozilla-inbound/rev/691765a17f17 https://hg.mozilla.org/integration/mozilla-inbound/rev/da8b3d934b13 https://hg.mozilla.org/integration/mozilla-inbound/rev/b05184e2f313
Target Milestone: --- → mozilla17
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/23460a801bb6 https://hg.mozilla.org/mozilla-central/rev/691765a17f17 https://hg.mozilla.org/mozilla-central/rev/da8b3d934b13 https://hg.mozilla.org/mozilla-central/rev/b05184e2f313
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•