Clean up nsPresContext

RESOLVED FIXED in mozilla17

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 646929 [details] [diff] [review]
Part 1: mLanguage should be an nsCOMPtr
Attachment #646929 - Flags: review?(roc)
(Assignee)

Comment 2

5 years ago
Created attachment 646930 [details] [diff] [review]
PArt 2: mEventManager should be nsRefPtr
Attachment #646930 - Flags: review?(roc)
(Assignee)

Comment 3

5 years ago
Created attachment 646932 [details] [diff] [review]
Part 3: Clean up includes
Attachment #646932 - Flags: review?(roc)
(Assignee)

Comment 4

5 years ago
Created attachment 646933 [details] [diff] [review]
Part 3: Clean up includes
Attachment #646932 - Attachment is obsolete: true
Attachment #646932 - Flags: review?(roc)
Attachment #646933 - Flags: review?(roc)
Attachment #646929 - Flags: review?(roc) → review+
Attachment #646930 - Flags: review?(roc) → review+
Comment on attachment 646933 [details] [diff] [review]
Part 3: Clean up includes

Review of attachment 646933 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that

::: layout/base/nsPresContext.cpp
@@ +1547,5 @@
> +#ifdef _IMPL_NS_LAYOUT
> +  return BidiEnabledInternal();
> +#else
> +  return BidiEnabledExternal();
> +#endif

_IMPL_NS_LAYOUT is always defined in this file, so this defeats the whole point of BidiEnabledExternal. I think you should keep BidiEnabled as it was, inline in nsPresContext.h.
Attachment #646933 - Flags: review?(roc) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 647039 [details] [diff] [review]
Part 4: DeviceContext should be nsRefPtr
Attachment #647039 - Flags: review?(roc)
Attachment #647039 - Flags: review?(roc) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/23460a801bb6
https://hg.mozilla.org/integration/mozilla-inbound/rev/691765a17f17
https://hg.mozilla.org/integration/mozilla-inbound/rev/da8b3d934b13
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05184e2f313
Target Milestone: --- → mozilla17

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/23460a801bb6
https://hg.mozilla.org/mozilla-central/rev/691765a17f17
https://hg.mozilla.org/mozilla-central/rev/da8b3d934b13
https://hg.mozilla.org/mozilla-central/rev/b05184e2f313
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.