778501 - Clean up nsPresContext

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Part 1: mLanguage should be an nsCOMPtr

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: PArt 2: mEventManager should be nsRefPtr

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: Part 3: Clean up includes

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: Part 3: Clean up includes

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 646933 [details] [diff] [review]
Part 3: Clean up includes

Review of attachment 646933 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that

::: layout/base/nsPresContext.cpp
@@ +1547,5 @@
> +#ifdef _IMPL_NS_LAYOUT
> +  return BidiEnabledInternal();
> +#else
> +  return BidiEnabledExternal();
> +#endif

_IMPL_NS_LAYOUT is always defined in this file, so this defeats the whole point of BidiEnabledExternal. I think you should keep BidiEnabled as it was, inline in nsPresContext.h.

Comment 6

[David Zbarsky (:dzbarsky)]

Attachment: Part 4: DeviceContext should be nsRefPtr

Comment 7

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23460a801bb6
https://hg.mozilla.org/integration/mozilla-inbound/rev/691765a17f17
https://hg.mozilla.org/integration/mozilla-inbound/rev/da8b3d934b13
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05184e2f313

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/23460a801bb6
https://hg.mozilla.org/mozilla-central/rev/691765a17f17
https://hg.mozilla.org/mozilla-central/rev/da8b3d934b13
https://hg.mozilla.org/mozilla-central/rev/b05184e2f313