Last Comment Bug 778519 - Don't include Layers.h everywhere Part 2
: Don't include Layers.h everywhere Part 2
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla17
Assigned To: David Zbarsky (:dzbarsky)
: Milan Sreckovic [:milan]
Depends on:
Blocks: includehell
  Show dependency treegraph
Reported: 2012-07-29 00:09 PDT by David Zbarsky (:dzbarsky)
Modified: 2013-02-26 17:41 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (46.69 KB, patch)
2012-07-29 00:09 PDT, David Zbarsky (:dzbarsky)
no flags Details | Diff | Splinter Review

Description User image David Zbarsky (:dzbarsky) 2012-07-29 00:09:57 PDT
Created attachment 646951 [details] [diff] [review]
Comment 1 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-30 13:07:03 PDT
Comment on attachment 646951 [details] [diff] [review]

>diff --git a/gfx/layers/basic/LayersBufferMode.h b/gfx/layers/basic/LayersBufferMode.h

Per IRL chat, would prefer to merge this with LayersBackend as a
header "LayersTypes.h" or something, since there are no users of one
type but not the other currently.

Otherwise looks fine.
Comment 2 User image David Zbarsky (:dzbarsky) 2012-07-30 19:22:20 PDT
Comment 3 User image Ed Morley [:emorley] 2012-07-31 06:11:16 PDT
Comment 4 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2013-02-26 17:41:31 PST
Oh bother.  This created a new FrameMetrics.h file instead of hg cp'ing :(.  My fault as a reviewer.

Note You need to log in before you can comment on or make changes to this bug.