778577 - Tab count number draws on top of the arrow with scaled font sizes

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

(On ICS)
1) Open Settings
2) Click "Display"
3) Click "Font Size" and select "Huge"
4) Hit the home button
5) Open Firefox

Expected: The tab count number is separated from the arrow
Actual: The tab count number draws on top of the arrow

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

Sorry, probably should have just taken it in the first place.

Not sure why there was an extra values-v11 dimen for this so I removed it.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch v2

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 647019 [details] [diff] [review]
Patch v2

Sorry, missed a few.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 647019 [details] [diff] [review]
Patch v2

Review of attachment 647019 [details] [diff] [review]:
-----------------------------------------------------------------

1. Font sizes should never ever be in "dp". "sp" (scalable) is the recommended unit for font sizes.
2. Huge is not going to be used by people (or atleast it's a new option). We need to do it in a different way -- like textAppearanceSmall, textAppearanceLarge and so on.
This is an overall change, currently in ibarlow's review radar, and will be done for all elements.
We can reopen this bug, if that big change doesn't fix this.

Comment 5

[Matt Brubeck (:mbrubeck)]

Perhaps we should check this patch in as a short-term fix (for Firefox 15 and 16) and fix the broader issue later?  Until the layout can properly handle scaled text, it seems like a hard-coded dp size is better here.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Hardcoded dp size is disruptive. We shouldn't be doing that with text. The text below thumbnails in about:home are screwed up because we've been using "9dp" instead of "9sp" -- which is so wrong.

This is not going to affect many users. Please.. no "dp" for text.. pleaseee....

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.