[Azure] Add a reftest sandbox flag for a mismatch between Azure backends

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nrc, Assigned: nrc)

Tracking

15 Branch
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
We would like to be able to add fuzz to tests if canvas and content are rendered using different backends.
(Assignee)

Comment 1

5 years ago
Created attachment 647048 [details] [diff] [review]
patch
Attachment #647048 - Flags: review?(roc)
Comment on attachment 647048 [details] [diff] [review]
patch

Review of attachment 647048 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/reftest.js
@@ +489,5 @@
>      sandbox.azureQuartz = gfxInfo.getInfo().AzureCanvasBackend == "quartz";
>      sandbox.azureSkia = gfxInfo.getInfo().AzureCanvasBackend == "skia";
> +    // true if we are using a different Azure backend for rendering canvas and content
> +    sandbox.azureMismatch = gfxInfo.getInfo().AzureContentBackend != gfxInfo.getInfo().AzureCanvasBackend
> +                            && !(gfxInfo.getInfo().AzureContentBackend == "none" && gfxInfo.getInfo().AzureCanvasBackend == "cairo");

How about "sandbox.contentSameGfxBackendAsCanvas"?
(Assignee)

Comment 3

5 years ago
Created attachment 647069 [details] [diff] [review]
patch

changed the name of the flag
Attachment #647048 - Attachment is obsolete: true
Attachment #647048 - Flags: review?(roc)
Attachment #647069 - Flags: review?(roc)
Comment on attachment 647069 [details] [diff] [review]
patch

Review of attachment 647069 [details] [diff] [review]:
-----------------------------------------------------------------

Hoist gfxInfo.getInfo() into a local variable, eh?
Attachment #647069 - Flags: review?(roc) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 647298 [details] [diff] [review]
patch

hoisted gfxInfo.GetInfo(), carrying r=roc
Attachment #647069 - Attachment is obsolete: true
Attachment #647298 - Flags: review+
(Assignee)

Comment 6

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=e4baff472b7f
(Assignee)

Comment 7

5 years ago
backed out: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=cda1c40da986
(Assignee)

Comment 8

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7198b3ea1763
https://hg.mozilla.org/mozilla-central/rev/ce9bc8ec663d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.