The default bug view has changed. See this FAQ.

Intermittent browser_webconsole_position_ui.js | Timed out while waiting for: web console position changed to 'window'

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: msucan)

Tracking

({intermittent-failure})

Trunk
Firefox 17
All
Mac OS X
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox16 unaffected, firefox17 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This started when bug 688981 landed on mozilla-central and inbound.

https://tbpl.mozilla.org/php/getParsedLog.php?id=13952435&tree=Mozilla-Inbound

Rev4 MacOSX Lion 10.7 mozilla-inbound opt test mochitest-other on 2012-07-29 16:03:28 PDT for push 36c30260e7fa
slave: talos-r4-lion-014

TEST-START | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | positionConsole() is available
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | menuitem for above positioning calls positionConsole() correctly
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | menuitem for below positioning calls positionConsole() correctly
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | menuitem for window positioning calls positionConsole() correctly
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | initial console position is correct
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | position menu checkbox is below
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | pref is below
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | web console position changed to 'above'
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | above position is correct
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | position menu checkbox is above
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | pref is above
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | Timed out while waiting for: web console position changed to 'window'
Stack trace:
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/head.js :: wait :: line 241
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/head.js :: <TOP_LEVEL> :: line 251
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_position_ui.js | finished in 5449ms
(Reporter)

Comment 1

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=13953199&tree=Firefox
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

5 years ago
Assignee: nobody → mihai.sucan
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
status-firefox16: --- → unaffected
status-firefox17: --- → affected
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 32

5 years ago
Created attachment 648361 [details] [diff] [review]
proposed fix

Green try runs:
https://tbpl.mozilla.org/?tree=Try&rev=21fb97db3316

Explanation:

1. I made changes so I was able to repro the failure on my system.
2. Found that the iframe onload event fires before popupshown (window positioning), so some code never executed - the test waited 5 seconds for specific changes in the HUD object, then timed out. The _afterPositionConsole() method added the load event listener in the popupshown event handler.
3. Solution: add the onload event listener before we move the iframe element in the DOM, not after.

Results are green after 50+ repeated runs on my system. Also green on try servers.
Attachment #648361 - Flags: review?(rcampbell)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment on attachment 648361 [details] [diff] [review]
proposed fix

R+++++++!!!
Attachment #648361 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/8d1a0d6f5703
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
<3

Thank you!
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
status-firefox17: affected → fixed
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.