778684 - Ensure `MOZ_WINCONSOLE` preprocessor definition exists if env var is 1

Status: RESOLVED WONTFIX

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

I think this only has a minor affect on Thunderbird/SeaMonkey but I think we probably want to port the configure.in change.

+++ This bug was initially created as a clone of Bug #773865 +++

The `MOZ_WINCONSOLE` env var is used to determine whether the application being built should be built as a console app or as a Windows app [1].  In some files, `MOZ_WINCONSOLE` is used as a preprocessor definition [2][3][4].  Setting up the preprocessor definition requires modifying the makefile of each module that wants to use the definition, e.g. [5].  In some cases we are not doing this correctly.  For example, in browser/app/nsBrowserApp.cpp, it is currently impossible for the `#ifdef MOZ_WINCONSOLE` branch to be compiled.

The attached patch changes config.mk to set up the preprocessor definition `MOZ_WINCONSOLE` if the env var is 1.

[1] https://mxr.mozilla.org/mozilla-central/source/config/config.mk?rev=88aaf6c529b9#583
[2] https://mxr.mozilla.org/mozilla-central/source/xulrunner/stub/nsXULStub.cpp?rev=a15d75939cd5#56
[3] https://mxr.mozilla.org/mozilla-central/source/xulrunner/app/nsXULRunnerApp.cpp?rev=3f408698a03f#52
[4] https://mxr.mozilla.org/mozilla-central/source/browser/app/nsBrowserApp.cpp?rev=601e2a3564ac#46
[5] https://mxr.mozilla.org/mozilla-central/source/xulrunner/app/Makefile.in#60

Comment 1

[:aceman]

Sorry, can't build on Windows.

Comment 2

[Joshua Cranmer [:jcranmer]]

Porting most configure options is unnecessary these days.