Closed Bug 778695 Opened 11 years ago Closed 11 years ago

Intermittent 328829-2.xhtml | image comparison (==)

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox17 --- fixed
firefox18 --- fixed
firefox19 --- fixed
firefox-esr17 --- fixed

People

(Reporter: emorley, Assigned: froydnj)

References

Details

(Keywords: intermittent-failure, Whiteboard: [qa-])

Attachments

(1 file)

patch
1.52 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
Rev3 WINNT 5.1 mozilla-inbound opt test reftest on 2012-07-27 22:22:07 PDT for push b5b442d9c305

slave: talos-r3-xp-042

https://tbpl.mozilla.org/php/getParsedLog.php?id=13930908&tree=Mozilla-Inbound

{
REFTEST TEST-START | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/bugs/328829-2.xhtml | 1642 / 8066 (20%)
REFTEST TEST-START | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/bugs/328829-2-ref.xhtml | 1642 / 8066 (20%)
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/bugs/328829-2.xhtml | image comparison (==)
REFTEST max difference: 255 number of differing pixels: 711
}
Attached patch patch — — Splinter Review 
As discussed on IRC, this should be using reftest-wait.
Attachment #675905 - Flags: review?(dholbert)
Comment on attachment 675905 [details] [diff] [review]
patch

># HG changeset patch
># User Nathan Froyd <froydnj@gmail.com>
>
>fix layout/reftests/bugs/328829-2.xhtml intermittent orange by using MozReftestInvalidate

Nit: checkin message should also mention "reftest-wait", since that's the part that's actually going to fix the intermittent failure, presumably.

r=me with that
Attachment #675905 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/9e3d4423e37f
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [orange] → [orange][qa-]
Whiteboard: [orange][qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.