Closed
Bug 778862
Opened 13 years ago
Closed 13 years ago
Change layout_* "match_parent" tags to "fill_parent"
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file, 1 obsolete file)
4.81 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
A search on mxr finds some hits for "match_parent": https://mxr.mozilla.org/mozilla-central/search?string=match_parent&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
These should be replaced with "fill_parent", as "match_parent" can cause issues on older Android versions.
Assignee | ||
Comment 1•13 years ago
|
||
I did not change anything in m-c/embedding because I only have a vague idea of what it is and more importantly, I don't know how to test it.
Attachment #647412 -
Flags: review?(sriram)
Assignee | ||
Comment 2•13 years ago
|
||
Rebase to trunk.
Attachment #647412 -
Attachment is obsolete: true
Attachment #647412 -
Flags: review?(sriram)
Attachment #647419 -
Flags: review?(sriram)
Comment 3•13 years ago
|
||
Comment on attachment 647419 [details] [diff] [review]
Patch v2
Review of attachment 647419 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good.
Attachment #647419 -
Flags: review?(sriram) → review+
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 4•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•