Closed Bug 778862 Opened 9 years ago Closed 9 years ago

Change layout_* "match_parent" tags to "fill_parent"

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 17

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(1 file, 1 obsolete file)

A search on mxr finds some hits for "match_parent": https://mxr.mozilla.org/mozilla-central/search?string=match_parent&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

These should be replaced with "fill_parent", as "match_parent" can cause issues on older Android versions.
Attached patch Patch (obsolete) — Splinter Review
I did not change anything in m-c/embedding because I only have a vague idea of what it is and more importantly, I don't know how to test it.
Attachment #647412 - Flags: review?(sriram)
Attached patch Patch v2Splinter Review
Rebase to trunk.
Attachment #647412 - Attachment is obsolete: true
Attachment #647412 - Flags: review?(sriram)
Attachment #647419 - Flags: review?(sriram)
Comment on attachment 647419 [details] [diff] [review]
Patch v2

Review of attachment 647419 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good.
Attachment #647419 - Flags: review?(sriram) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7fe2e18675f8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.