778879 - Relative URL code for Reader Mode should use Services.jsm

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

From bug 776110, mfinkle:
> Comment on attachment 645802 [details] [diff] [review]
> Patch v2
> 
> >diff --git a/mobile/android/chrome/content/Readability.js b/mobile/android/chrome/content/Readability.js
> 
> >+  _fixRelativeUris: function(articleContent) {
> >+    let baseUri = this._uri;
> >+    let ioService = Cc["@mozilla.org/network/io-service;1"]
> >+        .getService(Components.interfaces.nsIIOService);
> 
> Note for a followup bug: We try to use Services.jsm to acquire any supported
> services. In this case importing Services.jsm and using Services.ios would
> be enough.

That should be changed.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2903be101c32

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2903be101c32