Closed Bug 778879 Opened 9 years ago Closed 9 years ago

Relative URL code for Reader Mode should use Services.jsm

Categories

(Firefox for Android Graveyard :: Reader View, defect)

ARM
Android
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 17

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(1 file)

From bug 776110, mfinkle:
> Comment on attachment 645802 [details] [diff] [review]
> Patch v2
> 
> >diff --git a/mobile/android/chrome/content/Readability.js b/mobile/android/chrome/content/Readability.js
> 
> >+  _fixRelativeUris: function(articleContent) {
> >+    let baseUri = this._uri;
> >+    let ioService = Cc["@mozilla.org/network/io-service;1"]
> >+        .getService(Components.interfaces.nsIIOService);
> 
> Note for a followup bug: We try to use Services.jsm to acquire any supported
> services. In this case importing Services.jsm and using Services.ios would
> be enough.

That should be changed.
Attached patch PatchSplinter Review
Attachment #647415 - Flags: review?(mark.finkle)
Attachment #647415 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/2903be101c32
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.