Closed
Bug 778879
Opened 12 years ago
Closed 12 years ago
Relative URL code for Reader Mode should use Services.jsm
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file)
1.96 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
From bug 776110, mfinkle: > Comment on attachment 645802 [details] [diff] [review] > Patch v2 > > >diff --git a/mobile/android/chrome/content/Readability.js b/mobile/android/chrome/content/Readability.js > > >+ _fixRelativeUris: function(articleContent) { > >+ let baseUri = this._uri; > >+ let ioService = Cc["@mozilla.org/network/io-service;1"] > >+ .getService(Components.interfaces.nsIIOService); > > Note for a followup bug: We try to use Services.jsm to acquire any supported > services. In this case importing Services.jsm and using Services.ios would > be enough. That should be changed.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #647415 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #647415 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2903be101c32
Flags: in-testsuite-
Keywords: checkin-needed
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2903be101c32
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Updated•12 years ago
|
status-firefox17:
affected → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•