779010 - nsStyleSides comparison always assume Calc values are different

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Compare calc values

This is causing unnecessary invalidation in Gaia.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 647374 [details] [diff] [review]
Compare calc values

Could you just get rid of this macro and construct an nsStyleCoord for each side?  nsStyleCoord::nsStyleCoord(const nsStyleUnion&, nsStyleUnit) is inline and quite cheap, and then this logic will be in one place (nsStyleCoord::operator==) rather than two.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 647374 [details] [diff] [review]
Compare calc values

Good catch, though, but I'd like this not to happen in the future (see previous comment).

(Alternatively, if you think that there would be a performance difference, you could refactor the macro so it's used by both places and there's only one thing to change.  But I don't think it's worth it.)

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Compare calc values v2

Seems reasonable, updated the patch

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 647393 [details] [diff] [review]
Compare calc values v2

r=dbaron.  Thanks for finding and fixing this.

Comment 5

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a57c83db51a7

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a57c83db51a7

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Mochitest for this bug

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 647659 [details] [diff] [review]
Mochitest for this bug

r=dbaron