Calling gFormSubmitObserver.panelIsOpen() causes layout flushes (Port Bug 752486)

RESOLVED FIXED in seamonkey2.14

Status

SeaMonkey
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Ekanan Ketunuti)

Tracking

Trunk
seamonkey2.14
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js][mentor=Philip.Chee][level=apprentice])

Attachments

(1 attachment)

1.72 KB, patch
neil@parkwaycc.co.uk
: review+
Philip Chee
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
From Bug 752486:

> Calling gFormSubmitObserver.panelIsOpen() causes layout flushes:
> 
> #0  PresShell::FlushPendingNotifications (this=0x7fd14a3149f0, aType=Flush_Style)
>     at /home/tim/workspace/fx-team/layout/base/nsPresShell.cpp:3755
> #1  0x00007fd154a61ca8 in nsBoxObject::GetFrame (this=0x7fd1320f6700, aFlushLayout=false)
>     at /home/tim/workspace/fx-team/layout/xul/base/src/nsBoxObject.cpp:156
> #2  0x00007fd154a60de8 in nsPopupBoxObject::GetMenuPopupFrame (this=<optimized out>)
>     at /home/tim/workspace/fx-team/layout/xul/base/src/nsPopupBoxObject.cpp:69
> #3  0x00007fd154a60ffd in nsPopupBoxObject::GetPopupState (this=0x7fd1320f6700, aState=...)
>     at /home/tim/workspace/fx-team/layout/xul/base/src/nsPopupBoxObject.cpp:241
> 
> This is unfortunate because this is always called onLocationChange that is
> when switching tabs or navigating in a tab.
>
(Assignee)

Comment 1

5 years ago
Created attachment 647809 [details] [diff] [review]
patch
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #647809 - Flags: review?(neil)
Attachment #647809 - Flags: feedback?(philip.chee)

Comment 2

5 years ago
Comment on attachment 647809 [details] [diff] [review]
patch

panel probably isn't null at this point, but the check is harmless.
Attachment #647809 - Flags: review?(neil) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9f49374d9678
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
(Reporter)

Comment 4

5 years ago
Comment on attachment 647809 [details] [diff] [review]
patch

Sorry for the delay. Here's a post-facto f+
Attachment #647809 - Flags: feedback?(philip.chee) → feedback+
You need to log in before you can comment on or make changes to this bug.