Closed
Bug 779076
Opened 13 years ago
Closed 13 years ago
Calling gFormSubmitObserver.panelIsOpen() causes layout flushes (Port Bug 752486)
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.14
People
(Reporter: philip.chee, Assigned: ananuti)
Details
(Whiteboard: [good first bug][lang=js][mentor=Philip.Chee][level=apprentice])
Attachments
(1 file)
|
1.72 KB,
patch
|
neil
:
review+
philip.chee
:
feedback+
|
Details | Diff | Splinter Review |
From Bug 752486:
> Calling gFormSubmitObserver.panelIsOpen() causes layout flushes:
>
> #0 PresShell::FlushPendingNotifications (this=0x7fd14a3149f0, aType=Flush_Style)
> at /home/tim/workspace/fx-team/layout/base/nsPresShell.cpp:3755
> #1 0x00007fd154a61ca8 in nsBoxObject::GetFrame (this=0x7fd1320f6700, aFlushLayout=false)
> at /home/tim/workspace/fx-team/layout/xul/base/src/nsBoxObject.cpp:156
> #2 0x00007fd154a60de8 in nsPopupBoxObject::GetMenuPopupFrame (this=<optimized out>)
> at /home/tim/workspace/fx-team/layout/xul/base/src/nsPopupBoxObject.cpp:69
> #3 0x00007fd154a60ffd in nsPopupBoxObject::GetPopupState (this=0x7fd1320f6700, aState=...)
> at /home/tim/workspace/fx-team/layout/xul/base/src/nsPopupBoxObject.cpp:241
>
> This is unfortunate because this is always called onLocationChange that is
> when switching tabs or navigating in a tab.
>
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #647809 -
Flags: review?(neil)
Attachment #647809 -
Flags: feedback?(philip.chee)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 647809 [details] [diff] [review]
patch
panel probably isn't null at this point, but the check is harmless.
Attachment #647809 -
Flags: review?(neil) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
|
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 647809 [details] [diff] [review]
patch
Sorry for the delay. Here's a post-facto f+
Attachment #647809 -
Flags: feedback?(philip.chee) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•