779084 - Move querySelector stuff out of nsGenericElement and into nsINode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

(In reply to Boris Zbarsky (:bz) from bug 563659 comment #25)
> Can you file a followup bug to move the querySelector stuff out of
> nsGenericElement into nsINode.cpp?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Aryeh, David, does one of you want to do this?

Comment 2

[David Zbarsky (:dzbarsky)]

Aryeh, if you don't want this, I'll do it eventually.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I think I'll pass on this.

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: Patch

I left in the quickstub for queryselector because the signature doesn't match what quickstubs expects.  I don't think it's worth changing the signature since we'll change it anyway for webidl.

Comment 5

[David Zbarsky (:dzbarsky)]

Ah, I shouldn't have removed that nsIContent.h include.  I'll put it back

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 656684 [details] [diff] [review]
Patch

Can you remove the CSSRuleProcessor and CSSParser includes from FragmentOrElement.cpp?

r=me with that.  Thanks!

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 656684 [details] [diff] [review]
Patch

Review of attachment 656684 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsINode.cpp
@@ +2133,5 @@
> +
> +  NS_ASSERTION(selectorList->mSelectors,
> +               "How can we not have any selectors?");
> +
> +  nsIDocument* doc = aRoot->OwnerDoc();  

While you're here, please remove the trailing whitespace.

@@ +2235,5 @@
> +  return FindMatchingElements<false>(this, aSelector, *contentList);
> +}
> +
> +
> +

Leave out the newlines at the end here, please.

Comment 8

[David Zbarsky (:dzbarsky)]

Fixed the nits.
https://hg.mozilla.org/integration/mozilla-inbound/rev/58446a7c7540

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/58446a7c7540