Move querySelector stuff out of nsGenericElement and into nsINode

RESOLVED FIXED in mozilla18

Status

()

--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ayg, Assigned: dzbarsky)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bz][lang=c++])

Attachments

(1 attachment)

(In reply to Boris Zbarsky (:bz) from bug 563659 comment #25)
> Can you file a followup bug to move the querySelector stuff out of
> nsGenericElement into nsINode.cpp?
Aryeh, David, does one of you want to do this?
(Assignee)

Comment 2

6 years ago
Aryeh, if you don't want this, I'll do it eventually.
I think I'll pass on this.
(Assignee)

Updated

6 years ago
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Whiteboard: [mentor=bz]

Updated

6 years ago
Whiteboard: [mentor=bz] → [mentor=bz][lang=c++]
(Assignee)

Comment 4

6 years ago
Created attachment 656684 [details] [diff] [review]
Patch

I left in the quickstub for queryselector because the signature doesn't match what quickstubs expects.  I don't think it's worth changing the signature since we'll change it anyway for webidl.
Attachment #656684 - Flags: review?(bzbarsky)
(Assignee)

Comment 5

6 years ago
Ah, I shouldn't have removed that nsIContent.h include.  I'll put it back
Comment on attachment 656684 [details] [diff] [review]
Patch

Can you remove the CSSRuleProcessor and CSSParser includes from FragmentOrElement.cpp?

r=me with that.  Thanks!
Attachment #656684 - Flags: review?(bzbarsky) → review+
Comment on attachment 656684 [details] [diff] [review]
Patch

Review of attachment 656684 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsINode.cpp
@@ +2133,5 @@
> +
> +  NS_ASSERTION(selectorList->mSelectors,
> +               "How can we not have any selectors?");
> +
> +  nsIDocument* doc = aRoot->OwnerDoc();  

While you're here, please remove the trailing whitespace.

@@ +2235,5 @@
> +  return FindMatchingElements<false>(this, aSelector, *contentList);
> +}
> +
> +
> +

Leave out the newlines at the end here, please.
https://hg.mozilla.org/mozilla-central/rev/58446a7c7540
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.