779085 - Move attribute stuff from FragmentOrElement to nsGenericElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

(In reply to Boris Zbarsky (:bz) from bug 563659 comment #28)
> Is there a reason to implement HasAttributes/GetAttributes on the
> superclass, with switching on IsElement() instead of directly in subclasses?
> If not, a followup.

Comment 1

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Aryeh, do you want to take this?

If not, David, do you want to?

Comment 2

[David Zbarsky (:dzbarsky)]

Aryeh, if you don't want this, I'll do it eventually.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I have lots of other things to do right now, so probably not.

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Try run at https://tbpl.mozilla.org/?tree=Try&rev=e03fa6b54e7b

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 663055 [details] [diff] [review]
Patch

Review of attachment 663055 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsGenericElement.cpp
@@ +164,5 @@
> +{
> +  nsDOMSlots *slots = DOMSlots();
> +
> +  if (!slots->mAttributeMap) {
> +    slots->mAttributeMap = new nsDOMAttributeMap(this->AsElement());

Just 'this', I think.

Comment 6

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 663055 [details] [diff] [review]
Patch

Can you put this on nsGenericElement instead?

r=me with that and the nixed AsElement() bit.

Comment 7

[David Zbarsky (:dzbarsky)]

Sure, but isn't the plan to merge dom::Element and nsGenericElement?

Comment 8

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b3d73912991

Comment 9

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Plan is in flux on that.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b3d73912991