Closed
Bug 779085
Opened 9 years ago
Closed 9 years ago
Move attribute stuff from FragmentOrElement to nsGenericElement
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: ayg, Assigned: dzbarsky)
References
Details
(Whiteboard: [mentor=bz][lang=c++])
Attachments
(1 file)
2.57 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(In reply to Boris Zbarsky (:bz) from bug 563659 comment #28) > Is there a reason to implement HasAttributes/GetAttributes on the > superclass, with switching on IsElement() instead of directly in subclasses? > If not, a followup.
![]() |
||
Comment 1•9 years ago
|
||
Aryeh, do you want to take this? If not, David, do you want to?
Assignee | ||
Comment 2•9 years ago
|
||
Aryeh, if you don't want this, I'll do it eventually.
Reporter | ||
Comment 3•9 years ago
|
||
I have lots of other things to do right now, so probably not.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
![]() |
||
Updated•9 years ago
|
Whiteboard: [mentor=bz]
Updated•9 years ago
|
Whiteboard: [mentor=bz] → [mentor=bz][lang=c++]
Assignee | ||
Comment 4•9 years ago
|
||
Try run at https://tbpl.mozilla.org/?tree=Try&rev=e03fa6b54e7b
Attachment #663055 -
Flags: review?(bzbarsky)
Comment 5•9 years ago
|
||
Comment on attachment 663055 [details] [diff] [review] Patch Review of attachment 663055 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/src/nsGenericElement.cpp @@ +164,5 @@ > +{ > + nsDOMSlots *slots = DOMSlots(); > + > + if (!slots->mAttributeMap) { > + slots->mAttributeMap = new nsDOMAttributeMap(this->AsElement()); Just 'this', I think.
![]() |
||
Comment 6•9 years ago
|
||
Comment on attachment 663055 [details] [diff] [review] Patch Can you put this on nsGenericElement instead? r=me with that and the nixed AsElement() bit.
Attachment #663055 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Sure, but isn't the plan to merge dom::Element and nsGenericElement?
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b3d73912991
![]() |
||
Comment 9•9 years ago
|
||
Plan is in flux on that.
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b3d73912991
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•