The default bug view has changed. See this FAQ.

Some dom/plugins/ mochitests fail when the crash reporter is disabled

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: decoder, Assigned: decoder)

Tracking

({sec-want})

Trunk
mozilla17
sec-want
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [asan-test-failure])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It seems that we explicitly disable certain mochitest-chrome tests in dom/plugins/test/mochitest/Makefile.in when there is no crash reporter enabled, but there are also tests in mochitest-plain that require it to be enabled to work properly:

mochitest-plain failed:
74 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_crashing.html | This test did not leave any crash dumps behind, but we were expecting some!
372 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_hanging.html | This test did not leave any crash dumps behind, but we were expecting some!

This is turning ASan builds orange on mochitest-3 so I would like to fix this by enabling these tests only when the crash reporter is enabled.
Any test with "crashing" in the name ought to only be enabled when the crashreporter is enabled.
(Assignee)

Comment 2

5 years ago
Created attachment 647521 [details] [diff] [review]
Patch

These changes make the tests pass in that sub directory, even with the crash reporter disabled.
Assignee: nobody → choller
Status: NEW → ASSIGNED
Attachment #647521 - Flags: review?(ted.mielczarek)
Attachment #647521 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/90771aea4326
https://hg.mozilla.org/mozilla-central/rev/90771aea4326
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.