Last Comment Bug 779111 - Some dom/plugins/ mochitests fail when the crash reporter is disabled
: Some dom/plugins/ mochitests fail when the crash reporter is disabled
Status: RESOLVED FIXED
[asan-test-failure]
: sec-want
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Christian Holler (:decoder)
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-31 06:44 PDT by Christian Holler (:decoder)
Modified: 2012-08-02 19:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.50 KB, patch)
2012-07-31 07:17 PDT, Christian Holler (:decoder)
ted: review+
Details | Diff | Splinter Review

Description Christian Holler (:decoder) 2012-07-31 06:44:36 PDT
It seems that we explicitly disable certain mochitest-chrome tests in dom/plugins/test/mochitest/Makefile.in when there is no crash reporter enabled, but there are also tests in mochitest-plain that require it to be enabled to work properly:

mochitest-plain failed:
74 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_crashing.html | This test did not leave any crash dumps behind, but we were expecting some!
372 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_hanging.html | This test did not leave any crash dumps behind, but we were expecting some!

This is turning ASan builds orange on mochitest-3 so I would like to fix this by enabling these tests only when the crash reporter is enabled.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2012-07-31 06:47:08 PDT
Any test with "crashing" in the name ought to only be enabled when the crashreporter is enabled.
Comment 2 Christian Holler (:decoder) 2012-07-31 07:17:42 PDT
Created attachment 647521 [details] [diff] [review]
Patch

These changes make the tests pass in that sub directory, even with the crash reporter disabled.
Comment 3 Christian Holler (:decoder) 2012-08-02 14:04:38 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/90771aea4326
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-02 19:07:48 PDT
https://hg.mozilla.org/mozilla-central/rev/90771aea4326

Note You need to log in before you can comment on or make changes to this bug.