Closed Bug 779122 Opened 12 years ago Closed 12 years ago

nsXPCComponents_Utils::RecomputeWrappers returns bool instead of nsresult

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: ayg, Assigned: ayg)

References

Details

Bug 773962 part 4 added nsXPCComponents_Utils::RecomputeWrappers, which was declared as returning NS_IMETHODIMP.  But it returns the result of js::RecomputeWrappers, which returns a boolean, and/or the result of &&, which is also a boolean.  If the method is called from JS, AFAIK, this is the same as always returning NS_OK, so how about you return NS_OK here instead?
sure, r=me on a patch that does that.
Assignee: bobbyholley+bmo → ayg
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a62a2433ba1
Flags: in-testsuite-
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/7a62a2433ba1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.