Last Comment Bug 779122 - nsXPCComponents_Utils::RecomputeWrappers returns bool instead of nsresult
: nsXPCComponents_Utils::RecomputeWrappers returns bool instead of nsresult
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla17
Assigned To: Aryeh Gregor (:ayg) (working until September 2)
:
Mentors:
Depends on:
Blocks: 773962 nsresult-enum
  Show dependency treegraph
 
Reported: 2012-07-31 07:25 PDT by Aryeh Gregor (:ayg) (working until September 2)
Modified: 2012-08-01 10:53 PDT (History)
0 users
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Aryeh Gregor (:ayg) (working until September 2) 2012-07-31 07:25:44 PDT
Bug 773962 part 4 added nsXPCComponents_Utils::RecomputeWrappers, which was declared as returning NS_IMETHODIMP.  But it returns the result of js::RecomputeWrappers, which returns a boolean, and/or the result of &&, which is also a boolean.  If the method is called from JS, AFAIK, this is the same as always returning NS_OK, so how about you return NS_OK here instead?
Comment 1 Bobby Holley (:bholley) (busy with Stylo) 2012-07-31 07:29:16 PDT
sure, r=me on a patch that does that.
Comment 2 Aryeh Gregor (:ayg) (working until September 2) 2012-08-01 01:36:39 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a62a2433ba1
Comment 3 Ed Morley [:emorley] 2012-08-01 10:53:09 PDT
https://hg.mozilla.org/mozilla-central/rev/7a62a2433ba1

Note You need to log in before you can comment on or make changes to this bug.