Closed Bug 779123 Opened 9 years ago Closed 9 years ago
Doc Shell::Get Extended Origin returns false instead of NS _OK
Bug 776140 added nsDocShell::GetExtendedOrigin, with return value NS_IMETHODIMP. But it has "NS_ENSURE_TRUE(ssmgr, false)". This is identical to "NS_ENSURE_TRUE(ssmgr, NS_OK)", but possibly not intended, and at any rate confusing. Either it should return some type of error, or use NS_OK instead of false.
This is equivalent to the current code, except that it will still work once bug 777292 lands, but was the intent to actually return an error?
Assignee: jduell.mcbugs → ayg
Attachment #647889 - Flags: review?
Comment on attachment 647889 [details] [diff] [review] Patch, changes false to NS_OK Sigh, back+forward clears autocomplete=off fields like requestee . . .
Attachment #647889 - Flags: review? → review?(justin.lebar+bug)
Comment on attachment 647889 [details] [diff] [review] Patch, changes false to NS_OK It was likely intended to return an error; can you change it to NS_ERROR_FAILURE?
Attachment #647889 - Flags: review?(justin.lebar+bug) → review+
Yes, it should return NS_ERROR_FAILURE.
Target Milestone: --- → mozilla17
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.