nsDocShell::GetExtendedOrigin returns false instead of NS_OK

RESOLVED FIXED in mozilla17

Status

()

Core
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 776140 added nsDocShell::GetExtendedOrigin, with return value NS_IMETHODIMP.  But it has "NS_ENSURE_TRUE(ssmgr, false)".  This is identical to "NS_ENSURE_TRUE(ssmgr, NS_OK)", but possibly not intended, and at any rate confusing.  Either it should return some type of error, or use NS_OK instead of false.
Created attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK

This is equivalent to the current code, except that it will still work once bug 777292 lands, but was the intent to actually return an error?
Assignee: jduell.mcbugs → ayg
Attachment #647889 - Flags: review?
Comment on attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK

Sigh, back+forward clears autocomplete=off fields like requestee . . .
Attachment #647889 - Flags: review? → review?(justin.lebar+bug)
Comment on attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK

It was likely intended to return an error; can you change it to NS_ERROR_FAILURE?
Attachment #647889 - Flags: review?(justin.lebar+bug) → review+
Yes, it should return NS_ERROR_FAILURE.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d9891ef7bcb
Flags: in-testsuite-
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/8d9891ef7bcb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.