The default bug view has changed. See this FAQ.

GC: Incremental zeal modes interact badly with BudgetIncrementalGC

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jonco, Unassigned)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Currently IncrementalCollectSlice() determines whether it should do an incremental collection or not by checking whether the slice budget is unlimited, unless any of the incremental zeal modes are in effect in which case it will always perform an incremental slice as determined by the zeal mode.

BudgetIncrementalGC() sets the budget to unlimited to prevent an incremental GC in situations where it is not safe to do so.  This is therefore ignored when these zeal modes are in effect.

The solution is to pass a dummy slice budget that is not unlimited for the zeal mode GCs.  If the budget is later set to unlimited by BudgetIncrementalGC this will then be respectected.
(Reporter)

Updated

5 years ago
QA Contact: jcoppeard
(Reporter)

Comment 1

5 years ago
Created attachment 647573 [details] [diff] [review]
Proposed fix
Attachment #647573 - Flags: review?(wmccloskey)
Attachment #647573 - Flags: review?(wmccloskey) → review+
(Reporter)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/053116224bc9
https://hg.mozilla.org/mozilla-central/rev/053116224bc9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.