Closed
Bug 779172
Opened 12 years ago
Closed 12 years ago
GC: Incremental zeal modes interact badly with BudgetIncrementalGC
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jonco, Unassigned)
Details
Attachments
(1 file)
|
2.55 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Currently IncrementalCollectSlice() determines whether it should do an incremental collection or not by checking whether the slice budget is unlimited, unless any of the incremental zeal modes are in effect in which case it will always perform an incremental slice as determined by the zeal mode. BudgetIncrementalGC() sets the budget to unlimited to prevent an incremental GC in situations where it is not safe to do so. This is therefore ignored when these zeal modes are in effect. The solution is to pass a dummy slice budget that is not unlimited for the zeal mode GCs. If the budget is later set to unlimited by BudgetIncrementalGC this will then be respectected.
|
Reporter | |
Updated•12 years ago
|
QA Contact: jcoppeard
|
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #647573 -
Flags: review?(wmccloskey)
Attachment #647573 -
Flags: review?(wmccloskey) → review+
|
|
Reporter | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/053116224bc9
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/053116224bc9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•